Bug 2178167

Summary: Fullscreen mode is broken for many games
Product: [Fedora] Fedora Reporter: Kamil Páral <kparal>
Component: mutterAssignee: Florian Müllner <fmuellner>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: awilliam, decathorpe, fmuellner, fzatlouk, gnome-sig, jadahl, mweires, otaylor, philip.wyett, robatino, walters
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedBlocker
Fixed In Version: mutter-44.0-1.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-03-24 02:03:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2083912    

Description Kamil Páral 2023-03-14 12:32:25 UTC
With mutter-44~rc-4.fc38, many games fail to work in a fullscreen mode. If they automatically try to start in a fullscreen mode, you might not be able to run them at all. This is a regression from Fedora 37 (mutter 43).

This seems to be the go-to upstream issue:
https://gitlab.gnome.org/GNOME/mutter/-/issues/2678

My own report is here:
https://gitlab.gnome.org/GNOME/mutter/-/issues/2695

There seem to be two problems:
1. SDL doesn't play well with mutter 44.
2. Mutter 44 crashes because of a bug in gtk.

Problem #2 should be fixed in:
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5636

Problem #1 doesn't have a fix yet.

Proposing for a blocker discussion.

Comment 1 Adam Williamson 2023-03-20 23:52:46 UTC
Discussed at 2023-03-20 blocker review meeting: https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2023-03-20/f38-blocker-review.2023-03-20-16.00.html . This was accepted as a blocker; discussion in the blocker review meeting and also in the QA meeting that preceded it indicates there is a strong consensus to approve the currently-proposed release criterion around window management - see https://lists.fedoraproject.org/archives/list/test@lists.fedoraproject.org/message/UDMAC7IGJGHG4TBN32BPBCJCZOLWTDQG/ , and that the approved form of the criterion should cover this issue, so we decided that was sufficient to accept this.

Comment 2 mershl 2023-03-21 22:20:25 UTC
This issue is listed as fixed upstream for mutter 44.0
Fedora 38 is currently on mutter 44.rc

Comment 3 Adam Williamson 2023-03-22 00:53:24 UTC
We are aware of the upstream status, that's why the issue and merge requests are linked.

Comment 4 Fedora Update System 2023-03-22 23:39:40 UTC
FEDORA-2023-26137c2392 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-26137c2392

Comment 5 Adam Williamson 2023-03-22 23:41:20 UTC
The GTK crash fix should be stable already, it was in https://bodhi.fedoraproject.org/updates/FEDORA-2023-b6f25977ef . mutter 44.0 includes https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2921 , but not https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2910 (or the extended version of it discussed a bit in the upstream issue). I've marked https://bodhi.fedoraproject.org/updates/FEDORA-2023-26137c2392 (which has mutter 44.0) as fixing this issue; can you please check if it does fix it sufficiently? Thanks!

Comment 6 Fedora Update System 2023-03-23 02:56:33 UTC
FEDORA-2023-26137c2392 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-26137c2392

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Kamil Páral 2023-03-23 11:48:22 UTC
(In reply to Adam Williamson from comment #5)
> The GTK crash fix should be stable already, it was in
> https://bodhi.fedoraproject.org/updates/FEDORA-2023-b6f25977ef . mutter 44.0
> includes https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2921 , but
> not https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2910 (or the
> extended version of it discussed a bit in the upstream issue). I've marked
> https://bodhi.fedoraproject.org/updates/FEDORA-2023-26137c2392 (which has
> mutter 44.0) as fixing this issue; can you please check if it does fix it
> sufficiently? Thanks!

I tested with SteamWorld Heist, a game that was affected before. It works fine now. But it would be nice to get more feedback from other previously-affected games as well.

Comment 8 Fabio Valentini 2023-03-23 12:34:16 UTC
After updating to mutter v44.0 today, I tested two games that were previously broken ("Cities: Skylines" and "Mini Metro"), and both work fine now.

Comment 9 Fabio Valentini 2023-03-23 21:37:53 UTC
Side note: It seems that the "flickering" effect is fixed, but fullscreen windows sometimes seem to get stuck in a state where they *are* fullscreened but still have window decorations (and mouse position is offset by that additional window decoration). It can be worked around byg switching a game from "Fullscreen" to "Windowed" mode and then back to "Fullscreen", but doing that every time is annoying (especially because mouse clicks don't land where they should).

Comment 10 Adam Williamson 2023-03-23 22:18:52 UTC
Well yeah, that kinda makes sense, because the commit message of the commit that was reverted sounds a lot like it was intended to fix something like that. Still, if we only have a choice between the two bugs for now, that one seems the lesser of the two evils.

Comment 11 Fedora Update System 2023-03-24 02:03:38 UTC
FEDORA-2023-26137c2392 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.