Bug 2178204

Summary: [targetcli] Uncaught exception: AttributeError: 'UILUNs' object has no attribute 'rtsnode'
Product: Red Hat Enterprise Linux 9 Reporter: Martin Hoyer <mhoyer>
Component: targetcliAssignee: Maurizio Lombardi <mlombard>
Status: CLOSED MIGRATED QA Contact: Martin Hoyer <mhoyer>
Severity: low Docs Contact:
Priority: low    
Version: 9.2Keywords: MigratedToJIRA, Triaged
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-23 13:02:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Martin Hoyer 2023-03-14 14:18:22 UTC
Description of problem:
targetcli exits with exception when invalid storage_object is passed when creating lun.
Crashes observed with `luns/ create storage_object=` and `storage_object=.` 

/iscsi/iqn.20...49601261/tpg1> luns/ create 
Missing required parameter storage_object
/iscsi/iqn.20...49601261/tpg1> luns/ create storage_object=/invalid/path/
storage object or path not valid
/iscsi/iqn.20...49601261/tpg1> luns/ create storage_object=something
storage object or path not valid
/iscsi/iqn.20...49601261/tpg1> luns/ create storage_object=.
Traceback (most recent call last):
  File "/usr/bin/targetcli", line 329, in <module>
    main()
  File "/usr/bin/targetcli", line 317, in main
    shell.run_interactive()
  File "/usr/lib/python3.9/site-packages/configshell_fb/shell.py", line 900, in run_interactive
    self._cli_loop()
  File "/usr/lib/python3.9/site-packages/configshell_fb/shell.py", line 729, in _cli_loop
    self.run_cmdline(cmdline)
  File "/usr/lib/python3.9/site-packages/configshell_fb/shell.py", line 843, in run_cmdline
    self._execute_command(path, command, pparams, kparams)
  File "/usr/lib/python3.9/site-packages/configshell_fb/shell.py", line 818, in _execute_command
    result = target.execute_command(command, pparams, kparams)
  File "/usr/lib/python3.9/site-packages/configshell_fb/node.py", line 1406, in execute_command
    return method(*pparams, **kparams)
  File "/usr/lib/python3.9/site-packages/targetcli/ui_target.py", line 1122, in ui_command_create
    so = self.get_node(storage_object).rtsnode
AttributeError: 'UILUNs' object has no attribute 'rtsnode'


Version-Release number of selected component (if applicable):
python3-configshell-1:1.1.28-7.el9.noarch
python3-rtslib-2.1.75-1.el9.noarch
targetcli-2.1.53-7.el9.noarch   
kernel-5.14.0-283.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1.create iscsi tpg
2.attempt to create lun with `storage_object=`
3.observe exception

Actual results:
targetcli exits with python AttributeError

Expected results:
"storage object or path not valid" message, without exiting targetcli shell

Additional info:

Comment 1 RHEL Program Management 2023-09-23 13:01:13 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 2 RHEL Program Management 2023-09-23 13:02:19 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.