Bug 2178506

Summary:	17.1 - #3 - VMs in locked state - Fix issues with nova-manage volume_attachment subcommand
Product:	Red Hat OpenStack	Reporter:	Amit Uniyal <auniyal>
Component:	openstack-nova	Assignee:	OSP DFG:Compute <osp-dfg-compute>
Status:	ON_DEV ---	QA Contact:	OSP DFG:Compute <osp-dfg-compute>
Severity:	high	Docs Contact:
Priority:	high
Version:	17.1 (Wallaby)	CC:	alifshit, dasmith, eglynn, jhakimra, kchamart, osp-dfg-compute, sbauza, sgordon, vromanso
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Amit Uniyal 2023-03-15 06:22:19 UTC

This bug was initially created as a copy of Bug #2178500

I am copying this bug because: 



Work item: fix handling of instance locking. From the email thread:

>> 3- VMs in locked state
>>
>> This may be by design, but I'll say it here and let the compute team
>> decide on the correct behavior.
>>
>> On some failures, like the one from step #1, the refresh script leaves
>> the instance in a locked state instead of clearing it.
> 
> ya that kind of a bug.
> we put it in the locked state to make sure the end user cannot make any action like hard rebooting the instace
> while we are messing with the db. that is also why we require the vm to be off so that they cant power it off
> by sshing in.
> 
> regardless of the success or failure the reshsh command shoudl restore the lock state
> 
> so if it was locked before leave it locked and if it was unlocked leave it unlocked.
> so this sound like a bug in our error handeling and clean up



This bug was initially created as a copy of Bug #2161733

I am copying this bug because: 



Description of problem:

Gorka had to make heavy use of the `nova-manage volume_attachment` commands in resolving an escalation for Ericsson, and he had some feedback for us. We'd like to implement that feedback.

Version-Release number of selected component (if applicable):

From master all the way down to 16.2.

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

N/A

Expected results:

N/A

Additional info:

The thread where Gorka explains his feedback is at [1]. I'll try to break it down into specific fixes/work items in subsequent comments in this BZ.

[1] https://lists.corp.redhat.com/archives/rhos-compute/2022-December/000883.html