Bug 2178521

Summary:	User drop down menu improvements
Product:	[Community] Bugzilla	Reporter:	Milan Crha <mcrha>
Component:	User Interface	Assignee:	Jeff Fearn 🐞 <jfearn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jeff Fearn 🐞 <jfearn>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.0
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.0.4-rh88	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-03 00:17:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Crha 2023-03-15 07:29:35 UTC

I opened the browser today, with a link to a bug. The right-top corner showed my name and beside it a number "2" in a circle. The overall page looked like I'm authenticated, thus I wrote my comment and when I submitted it, I've been told I'm not logged in. What a surprise. The page to log in shown up (with an input field for my login/email address and password), with right-top corner saying "Login". I clicked the "Login" at the top and picked "Red Had Associate". Bugzilla yelled at me that it cannot process the request, it doesn't know what to do. An exact error is lost, I'm sorry. 

Then I went back in the browser (clicking the back button) as many times as I'm  back at the bug URL where I wrote my comment. Luckily, it's not lost, I can copy it. The right-top corner still claims my name and beside of it in red "expired". Okay, no problem, I'll re-login and that's it. Wrong. The menu under my name offers me only two clickable items, Preferences and Log Out. There is the third line with an info when the session expired. There is no re-login offer. What am I supposed to do now? I do not know, thus I clicked "Log out", as it was the closest option. It took me to the main bugzilla page, thus I lost context. I can then log in, as I'm forgotten by the bugzilla.

Summary:
a) login page should let me Login->Red Hat Associate from the right-top corner (it seems it's reproducible only when trying to save a comment from an expired session, I can login this way from plain login page, opened by a "login" link at the end of a bug page);

b) there should be some re-login option when the session expires, to make it easier to refresh the session and not lost the current context (where I am).

Comment 1 Jeff Fearn 🐞 2023-03-21 00:43:27 UTC

Hi, once logged in if you hover over your user name in the top right it will tell you when your session will expire. At the end of the time is an icon [1] that you can click to relogin. This widget should be functional even when the session has expired.

Is this icon not visible or not functional for you?

1: https://fontawesome.com/v5/icons/sign-in-alt?f=classic&s=solid

Comment 2 Milan Crha 2023-03-21 06:40:26 UTC

I did not notice the icon, neither I'd expect from it to be used for re-login. I searched for a re-login entry in the popup menu under my name. Looking at it now, I see in that popup menu:

   Preferences
   Log out
   
      Session expires at
   3/21/2023, 11:21:23PM  >]

where the ">]" is the icon you talked about. That the whole two last lines are in a significantly smaller font than the other items in the menu - it looks like an information only - I did not notice, neither looked for, an active element in it.

It can be my fault, no doubt.

Feel free to close this, the icon is there and it seems somewhat active - when I hover a mouse above it - it's only not visible enough to be noticed by me.

Comment 3 Jeff Fearn 🐞 2023-03-22 01:31:38 UTC

The menu is a mix of old and new styles and needs a tidy up.

Comment 4 Jeff Fearn 🐞 2023-06-28 01:41:28 UTC

On QA server.

1. The session expired display now has a pop-up title: "Your session has expired. Please select re-login from the account menu to start a new session before submitting changes."

2. The form validation check now also checks for session expiration. If the session is expired the submission will be blocked and the user informed to re-login before trying to submit.

3. The session timer and re-login frame have been moved in to the menu. This fixes an issue with the layout and makes it easier for screen readers to contextualize the content.

Comment 5 Jeff Fearn 🐞 2023-06-28 23:01:36 UTC

This fix has been deployed to stage Bugzilla for a short public testing phase.

https://bugzilla.stage.redhat.com

Comment 6 Jeff Fearn 🐞 2023-07-03 00:17:37 UTC

This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug.