Bug 2178695

Summary:	keepalived json support tied to sha1 in spec
Product:	Red Hat Enterprise Linux 9	Reporter:	Juraj Hrdlica <jhrdlica>
Component:	keepalived	Assignee:	Ryan O'Hara <rohara>
Status:	CLOSED NEXTRELEASE	QA Contact:	cluster-qe <cluster-qe>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.2	CC:	cluster-maint
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	keepalived-2.2.8-3.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-07 12:49:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juraj Hrdlica 2023-03-15 15:22:56 UTC

Description of problem:
If keepalived were to be built without "sha1" it would also get built without JSON support
and
if it were to be built without JSON support, it is not doable without also building it without sha1.

Actual keepalived.spec:
%build
%configure \
...
    %{?with_sha1:--enable-sha1} \
    %{?with_sha1:--enable-json} \ #the issue is this line
...

Expected keepalived.spec:
%build
%configure \
...
    %{?with_sha1:--enable-sha1} \
    %{?with_json:--enable-json} \
...

Version-Release number of selected component (if applicable):
keepalived-2.2.4-6.el9

Comment 2 Ryan O'Hara 2023-03-24 16:11:46 UTC

Original BZ requesting JSON support:

https://bugzilla.redhat.com/show_bug.cgi?id=2129819

Comment 3 Ryan O'Hara 2023-07-07 12:49:34 UTC

I fixed this in the most recent RHEL9 build. I didn't bother to mention it in the changelog nor do I believe we need to mention it in the errata because it was harmless and did not affect customers in any way. This was purely an issue of being correcting the spec file. The only way someone would notice this is if they were building packages with conditionals.