Bug 2178707

Upstream patch: https://github.com/ClusterLabs/pcs/commit/72ca3f550c63218f1f132e4c6b9a6d1cb0670d6f

Test:
# pcs constraint location dummy rule date lt '01-01-2022'
Error: 'date lt 01-01-2022' is not a valid rule expression: '01-01-2022' is not an ISO 8601 date

DevTestResults:

[root@r08-09-a ~]# rpm -q pcs
pcs-0.10.16-1.el8.x86_64

[root@r08-09-a ~]# pcs constraint location r1 rule date lt '01-01-2022'
Error: 'date lt 01-01-2022' is not a valid rule expression: '01-01-2022' is not an ISO 8601 date

## BEFORE

[root@virt-545 ~]# rpm -q pcs
pcs-0.10.15-4.el8.x86_64

[root@virt-545 ~]# pcs resource create d1 ocf:heartbeat:Dummy

[root@virt-545 ~]# echo $?
0

[root@virt-545 ~]# pcs resource
  * d1	(ocf::heartbeat:Dummy):	 Started virt-545


A). Entering invalid date format for location rule (not an ISO 8601 date)

[root@virt-545 ~]# pcs constraint location d1 rule date lt 22-06-2023

[root@virt-545 ~]# echo $?
0

[root@virt-545 ~]# pcs constraint location config
Location Constraints:
  Resource: d1
    Constraint: location-d1
      Rule: score=INFINITY
        Expression: date lt 22-06-2023

> In the previous version it was possible to specify a constraint rule with a date whose format was not correct (not an ISO8601 date format). This case did not return an error message and the return code was 0.


## AFTER

[root@virt-129 ~]# rpm -q pcs
pcs-0.10.16-1.el8.x86_64

[root@virt-129 ~]# pcs resource create d1 ocf:heartbeat:Dummy

[root@virt-129 ~]# echo $?
0

[root@virt-129 ~]# pcs resource
  * d1	(ocf::heartbeat:Dummy):	 Started virt-129

A.) Entering invalid date format(dd-mm-yyyy, not an ISO 8601 date)

[root@virt-129 ~]# pcs constraint location d1 rule date lt 22-06-2023
Error: 'date lt 22-06-2023' is not a valid rule expression: '22-06-2023' is not an ISO 8601 date

[root@virt-129 ~]# echo $?
1

[root@virt-129 ~]# pcs constraint location config
Location Constraints:

> OK.

B.) Entering another invalid date format (yyyy/month/dd)

[root@virt-129 ~]# pcs constraint location d1 rule date lt 2023/Jun/22
Error: 'date lt 2023/Jun/22' is not a valid rule expression: '2023/Jun/22' is not an ISO 8601 date

[root@virt-129 ~]# echo $?
1

[root@virt-129 ~]# pcs constraint location config
Location Constraints:

> OK.

C.) Entering US date format (mm/dd/yyyy, not an ISO 8601 date)

[root@virt-129 ~]# pcs constraint location d1 rule date lt 06/22/2023
Error: 'date lt 06/22/2023' is not a valid rule expression: '06/22/2023' is not an ISO 8601 date

[root@virt-129 ~]# echo $?
1

[root@virt-129 ~]# pcs constraint location config
Location Constraints:

> OK.

D.) Entering invalid date format (yyyy-mm/dd)

[root@virt-129 ~]# pcs constraint location d1 rule date lt 2023-06/23

[root@virt-129 ~]# echo $?
0

[root@virt-129 ~]# pcs constraint location config
Location Constraints:

> I am not sure about validity of this edge case. The first part of the date is OK and so it is possible that it is evaluated as a valid ISO 8601 date, but in this case the user is not notified that this date is an invalid date format. Also there is no warning/error message and it returns with 0 return code, however no actie location constraint is displayed. 

[root@virt-129 ~]# pcs constraint location config --all
Location Constraints:
  Resource: d1
    Constraint (expired): location-d1
      Rule (expired): score=INFINITY
        Expression: date lt 2023-06/23

[root@virt-129 ~]# date
Wed Jun 21 14:04:04 CEST 2023

> This location constraint rule is shown as expired even though it should not be expired yet. We have created a new BZ that addresses this issue (https://bugzilla.redhat.com/show_bug.cgi?id=2216492)

E.) Entering invalid date format (yyyy/mm-dd)

[root@virt-129 ~]# pcs constraint location d1 rule lt 2023/06-23
Error: 'lt 2023/06-23' is not a valid rule expression: unexpected 'lt'

[root@virt-129 ~]# echo $?
1

[root@virt-129 ~]# pcs constraint location config
Location Constraints:

> OK.

F.) Entering valid ISO 8601 basic date format

[root@virt-129 ~]# pcs constraint location d1 rule date lt 2023-06-22
[root@virt-129 ~]# echo $?
0
[root@virt-129 ~]# pcs constraint location config
Location Constraints:
  Resource: d1
    Constraint: location-d1
      Rule: score=INFINITY
        Expression: date lt 2023-06-22

> OK.

G.) Entering valid ISO 8601 week date format

[root@virt-129 ~]# pcs constraint location d1 rule date lt 2023-W25-4

[root@virt-129 ~]# echo $?
0

[root@virt-129 ~]# pcs constraint location config
Location Constraints:
  Resource: d1
    Constraint: location-d1
      Rule: score=INFINITY
        Expression: date lt 2023-W25-4

> OK.

H.) Entering valid ISO 8601 date format

[root@virt-129 ~]# pcs constraint location d1 rule date lt 2023-173

[root@virt-129 ~]# echo $?
0

[root@virt-129 ~]# pcs constraint location config
Location Constraints:
  Resource: d1
    Constraint: location-d1
      Rule: score=INFINITY
        Expression: date lt 2023-173

> OK.

I.) Entering more complex valid date expression

[root@virt-129 ~]# pcs constraint location d1 rule date in_range 2023-01-01 to 2023-175

[root@virt-129 ~]# echo $?
0

[root@virt-129 ~]# pcs constraint location config
Location Constraints:
  Resource: d1
    Constraint: location-d1
      Rule: score=INFINITY
        Expression: date in_range 2023-01-01 to 2023-175

> OK.

> Overall, working with dates that are specified in ISO 8601 standard works reliably. However, in my opinion, it would be useful to add an extra check to ensure that only ISO 8601 dates are supported (https://bugzilla.redhat.com/show_bug.cgi?id=2216492). 

> Marking as VERIFIED for pcs-0.10.16-1.el8.x86_64

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6903