Bug 2179226

Summary: Improve the name of "Add new" secret in catalog -> instanceTypes
Product: Container Native Virtualization (CNV) Reporter: Guohua Ouyang <gouyang>
Component: User ExperienceAssignee: Hilda Stastna <hstastna>
Status: CLOSED ERRATA QA Contact: Guohua Ouyang <gouyang>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.13.0CC: gouyang, hstastna
Target Milestone: ---   
Target Release: 4.13.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-18 02:58:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
add new button none

Description Guohua Ouyang 2023-03-17 05:32:56 UTC
Created attachment 1951399 [details]
add new button

Description of problem:
Create VM from instanceType and try to add new secret to the VM, there is a "Name" field in the section, it might cause confusion because it has the VM name just below it. So suggest renaming it to "Secret name" to make it clear what it's for.
And if put the name and the input dialog closer would be better.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Hilda Stastna 2023-03-17 17:46:06 UTC
Hi Guohua, 

> Create VM from instanceType and try to add new secret to the VM, there is a "Name" field in the section, it might cause confusion because it has the VM name just below it. So suggest renaming it to "Secret name" to make it clear what it's for.

Seems that yes, it was already designed to display "Secret name", see [1]. Also "Authorized SSH key" with the icon and help text should be displayed in that section, too, so the user knows what they can add when clicking on "Add new" radio button. Also one divider is missing in the UI, according to the design.

> And if put the name and the input dialog closer would be better.

I don't think so, this section was designed to be aligned as it is now. I remember some other issue you've raised earlier about the section not looking good here [2] (see your issue no. 5),
when the values were close to the field names. So due to that earlier issue it was designed to be aligned as it is now.

[1] https://docs.google.com/document/d/1HTF6_H2WDXwlVy7RnrHH28dzFlhNIa15Hhpeoyg2R0Q/edit#heading=h.cs83xz6k7ei3
[2] https://docs.google.com/document/d/1OiAPv4BeeyD0h6dJvvxJlHNx5-xkz1NyzWk-2cenbn4/edit#

Comment 2 Hilda Stastna 2023-03-17 19:45:38 UTC
But if you meant putting the "Secret name" closer to the input element, I agree with this.

Comment 3 Guohua Ouyang 2023-03-19 23:07:28 UTC
(In reply to Hilda Stastna from comment #2)
> But if you meant putting the "Secret name" closer to the input element, I
> agree with this.

That's what I mean.

Comment 4 Guohua Ouyang 2023-03-27 07:01:37 UTC
verified on 4.13.0

Comment 6 errata-xmlrpc 2023-05-18 02:58:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.13.0 Images security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:3205