Bug 2180614

Taking this review.

> License:       CC0-1.0

This is not allowed for code in Fedora. Please talk to upstream to fix it.

(Ignore the FE-Legal thing, that was an error)

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5691692
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2180614-ktextaddons/fedora-rawhide-x86_64/05691692-ktextaddons/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

If the CC0 material is limited to what's stated in the .reuse/dep5 file:
Files: autocorrection/src/autotests/data/* textgrammarcheck/grammalecte/autotests/data/*.json textgrammarcheck/languagetool/autotests/data/*.json

I'm comfortable saying that should be allowed as being "content" rather than code.

The full list of files which contain CC0 is:

README.md.license
sanitizers.supp
texttranslator/translator/plugins/google/CMakeLists.txt
texttranslator/translator/plugins/lingva/CMakeLists.txt
texttranslator/translator/plugins/bing/CMakeLists.txt
texttranslator/translator/plugins/yandex/CMakeLists.txt
texttranslator/translator/plugins/deepl/CMakeLists.txt
texttranslator/translator/plugins/libretranslate/CMakeLists.txt
texttranslator/translator/tests/CMakeLists.txt
texttranslator/designer/CMakeLists.txt
texttranslator/CMakeLists.txt
texttranslator/Messages.sh
metainfo.yaml.license
autocorrection/src/tests/CMakeLists.txt
autocorrection/src/autotests/CMakeLists.txt
autocorrection/src/CMakeLists.txt
autocorrection/src/Messages.sh
autocorrection/CMakeLists.txt
textgrammarcheck/CMakeLists.txt
textgrammarcheck/Messages.sh
textedittexttospeech/Messages.sh


I don't ship any of those files. I am a bit curious about the CMakeLists.txt files though. Are those ok?

Upstream main developer assures me he will change the license for the CMakeLists and .sh files this week.

Files have been relicensed upstream: https://invent.kde.org/libraries/ktextaddons/-/commit/8869e3393217d8be82a8d9c8cdfeb133374cd663

@rfontana : would you mind checking if the changes are enough? the commit for the 1.1 branch: https://invent.kde.org/libraries/ktextaddons/-/commit/12969971afe1b41d6fca9099d60e384768be3fb9

Thanks!

(In reply to marcdeop from comment #9)
> @rfontana : would you mind checking if the changes are enough?
> the commit for the 1.1 branch:
> https://invent.kde.org/libraries/ktextaddons/-/commit/
> 12969971afe1b41d6fca9099d60e384768be3fb9
> 
> Thanks!

I will just comment on the CC0 issue. I don't see any problems here for the Fedora CC0 policy, but one of the remaining CC0 files is the README.md which is currently basically empty. We have classified CC0 as allowed for "content" and disallowed generally (in particular for code) but haven't yet dealt with the issue of CC0 documentation. A non-empty README.md file should probably be classified as documentation. The current Fedora approach to documentation licensing is that "allowed-documentation" licenses have to meet all the requirements for normal "allowed" licenses, which CC0 doesn't. If the upstream developer were to actually populate the README.md file we'd have to face the question whether to make an exception for CC0 for documentation. We already have other CC licenses (which have the same problemlatic language about patents) grandfathered in to the allowed-documentation policy but we were disinclined to add CC0 because we didn't think it was commonly used for documentation in repositories otherwise not generally licensed under CC0. 

So there's nothing that has to be done here for this branch, but this could be an issue for the future, which the upstream developer could make disappear by picking a different license (e.g. BSD-3-Clause) for the possibly-someday-nonempty README.md :)

Updated spec file and srpm with a new bugfix release from upstream

This is good now.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/ktextaddons

IMHO, this package should be renamed to kf5-ktextaddons or ktextaddons-kf5, because there will undoubtedly be a KF6 version soon.