Bug 2180761

Summary:	problems with webhooks are only logged to production.log, no failed task, no other notification
Product:	Red Hat Satellite	Reporter:	Evgeni Golov <egolov>
Component:	Hooks and Webhooks	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED ERRATA	QA Contact:	Peter Ondrejka <pondrejk>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.13.0	CC:	ahumbe, aruzicka, lhellebr, rlavi
Target Milestone:	6.15.0	Keywords:	Triaged, UserExperience
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-foreman_webhooks-3.2.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-23 17:13:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Evgeni Golov 2023-03-22 08:24:55 UTC

Description of problem:
webhooks sometimes fail, but as an admin of a satellite I have no way to know about this without grepping /var/log/foreman/production.log

Version-Release number of selected component (if applicable):
any containing foreman_webhooks

How reproducible:
100%

Steps to Reproduce:
1. make a webhook fail
2. try to find out

Actual results:
only production.log has the data

Expected results:
either a failed task or a notification area entry or something that people can actually watch and react to

Additional info:

Comment 1 Brad Buckingham 2023-03-23 14:23:56 UTC

Would you consider this an RFE or defect?

Comment 2 Evgeni Golov 2023-03-23 14:34:24 UTC

I consider this a defect as it makes using/debugging the core functionality really hard.

Comment 3 Adam Ruzicka 2023-06-14 12:30:13 UTC

Would you happen to have an example? What kind of failure are we talking about?

Comment 4 Evgeni Golov 2023-06-15 07:05:13 UTC

I don't have an example at hand (but could generate you one if you want), but my memory says I had the two following failures where I wanted a more detailed info about:
1/ bad webhook url, so it would either run in a timeout or get a 404
2/ bad payload, which was rejected by the receiver with a 500 error (I guess technically it should have been a 422 - Unprocessable Entity, but the receiver I was using raised a 500)

Comment 6 Bryan Kearney 2023-11-07 16:02:30 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/32368 has been resolved.

Comment 7 Peter Ondrejka 2023-11-27 15:25:16 UTC

Verified in Satellite stream snap 38

Comment 10 errata-xmlrpc 2024-04-23 17:13:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010