Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2180981

Summary: sss allows extraneous @ characters prefixed to username #
Product: Red Hat Enterprise Linux 8 Reporter: Abhijit Roy <abroy>
Component: sssdAssignee: Tomas Halman <thalman>
Status: CLOSED ERRATA QA Contact: shridhar <sgadekar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 8.7CC: atikhono, ipedrosa, mescanfe, pbrezina, rakkumar, sgadekar
Target Milestone: rcKeywords: Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard: sync-to-jira
Fixed In Version: sssd-2.9.0-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-14 15:50:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Abhijit Roy 2023-03-22 18:48:10 UTC
Description of problem:

As per the upstream ticket https://github.com/SSSD/sssd/issues/6635 I am opening this bz.

Solution provided by Tomáš

Default re_expressions does not use "^" so they may skip/ignore some leading character (@ and \)
Changing

#define SSS_DEFAULT_RE "(?P<name>[^@]+)@?(?P<domain>[^@]*$)"
to

#define SSS_DEFAULT_RE "^(?P<name>[^@]+)@?(?P<domain>[^@]*$)"
and similar change for SSS_IPA_AD_DEFAULT_RE will solve the issue. It will make SSSD more strict about input values.

Consider that this regular expression is used also for group names and MS Windows group name can actually include @

$ grep "SSS_DEFAULT_RE" util/util.h 
#define SSS_DEFAULT_RE "(?P<name>[^@]+)@?(?P<domain>[^@]*$)"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Alexey Tikhonov 2023-03-23 14:17:11 UTC
*** Bug 2180998 has been marked as a duplicate of this bug. ***

Comment 2 Alexey Tikhonov 2023-03-24 09:44:44 UTC
Upstream PR: https://github.com/SSSD/sssd/pull/6646

Comment 3 Alexey Tikhonov 2023-04-14 10:14:48 UTC
Pushed PR: https://github.com/SSSD/sssd/pull/6646

* `master`
    * b78b508b1dbdb78c8d17916472a3398d67f76bbd - responder: regexp cleanup
    * 526aea3e8cb48dbfaabb009e06236828ad903429 - util: Improve re_expression defaults

Comment 16 errata-xmlrpc 2023-11-14 15:50:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sssd bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7127

Comment 17 Red Hat Bugzilla 2024-03-14 04:25:32 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days