Bug 2181025

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5696252
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181025-rust-linux-loader/fedora-rawhide-x86_64/05696252-rust-linux-loader/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package doesn't build in rawhide: The vm-memory v0.10.0 update is missing from rawhide.

I've updated this package to drop CODEOWNERS and coverage_config* files and to flag additional files as documentation.

1. Please also add the "/doc/" directory to the list of excluded files instead of marking it as %doc.

We don't ship any documentation for Rust packages (we also don't run rustdoc, for example), since they never end up on either end users' or even packagers' machines, and are only installed in temporary build environments.

2. Please add a short comment about what the patch does, i.e. something like

# * drop files that are only useful for upstream development
# * prevent documentation from being installed
# * remove unused, benchmark-only criterion dev-dependency

The spec and SRPM are updated to exclude docs and add comments.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 AND BSD-3-Clause) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Looks good to me.

According to the ticket linked in the initial comment, it seems the license of this crate should be "(Apache-2.0 OR BSD-3-Clause) AND BSD-3-Clause" as well? Either way, the current license string is "Apache-2.0 AND BSD-3-Clause", which should be fine for now (just with "less details") - and license texts for both licenses are included as well.

Just include a comment with the link to the upstream issue in the spec file, so we don't forget about it.
# https://github.com/rust-vmm/linux-loader/issues/136

===

Note that the crate does not seem to build correctly across all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=99237932

- x86_64: builds, tests pass
- aarch64: builds, tests pass
- i686: builds, some tests fail (harmless failures in tests generated by bindgen)
- s390x: builds, some tests pass, some doctests fail to compile
- s390x: builds, some tests pass, some doctests fail to compile

If I remember correctly, you said that firecracker is only supported on x86_64 and aarch64?
If that is the case, I would add "ExclusiveArch: x86_64 aarch64" to this package, with a comment that firecracker only supports these architectures.

Yes, sorry, this crate was supposed to have ExclusiveArch as well.  (The README says only x86_64 and aarch64 kernels are supported.)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linux-loader

FEDORA-2023-493feaccd3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-493feaccd3

FEDORA-2023-493feaccd3 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-02106a6c13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

FEDORA-2023-a4085b6295 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4085b6295 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.