Bug 2181028
| Summary: | Review Request: rust-userfaultfd - Rust bindings for the Linux userfaultfd functionality | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedora.dm0 |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/userfaultfd | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-28 12:45:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2181029 | ||
| Bug Blocks: | 2181039 | ||
|
Description
fedora.dm0
2023-03-22 21:43:30 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5696256 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181028-rust-userfaultfd/fedora-rawhide-x86_64/05696256-rust-userfaultfd/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me, with one exception: Some tests fail on ppc64le: https://koji.fedoraproject.org/koji/taskinfo?taskID=99195371 The previous version of this package skipped some tests on ppc64le: https://src.fedoraproject.org/rpms/rust-userfaultfd/blob/f36/f/rust-userfaultfd.spec#_92-101 I've reported the problem upstream (it seems to be related to page size being "different" (i.e. "not 4KiB") on ppc64le Fedora kernels): https://github.com/bytecodealliance/userfaultfd-rs/issues/32 Sorry, pushed the ?->+ button too fast :) Sorry, I missed that by only building for Firecracker's supported platforms (x86_64 and aarch64). The spec and SRPM are updated. Perfect, thanks! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (skipped tests are justified) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === You can proceed with the unretirement request now. The package needs to be unretired from the f37 and rawhide dist-git branches, and unblocked from the f37, f38, and f39 tags in koji. Unretire request: https://pagure.io/releng/issue/11361 FEDORA-2023-bc85a14eec has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bc85a14eec FEDORA-2023-bc85a14eec has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-02106a6c13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13 FEDORA-2023-a4085b6295 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295 FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4085b6295 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |