Bug 2181029
| Summary: | Review Request: rust-userfaultfd-sys - Low-level bindings for userfaultfd functionality on Linux | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedora.dm0 |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/userfaultfd-sys | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-27 13:26:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2181028, 2181039 | ||
|
Description
fedora.dm0
2023-03-22 21:47:41 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5696269 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2181029-rust-userfaultfd-sys/fedora-rawhide-x86_64/05696269-rust-userfaultfd-sys/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good to me, just two comments: 1. You can partially automate generating patches for Cargo.toml files with "rust2rpm -p". This also ensures that any changes to Cargo.toml that can affect contents of generated spec files are taken into account correctly (i.e. cargo metadata that's used for generating the spec file is loaded *after* the patch is applied). 2. When I previously worked on this package (before it was removed from Fedora 37+), I was able to run most tests: https://src.fedoraproject.org/rpms/rust-userfaultfd-sys/blob/f36/f/rust-userfaultfd-sys.spec#_91-92 It might be worth investigating if skipping this one test still makes the rest of the test suite pass. ===== Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (test suite is disabled with justification) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === You can now proceed with filing the unretirement request: https://pagure.io/releng/new_issue (select package_unretirement template in issue "Types" dropdown) I've updated this package to re-enable tests by default and skip the broken one and to replace the patch with the automatic format. Unretire request: https://pagure.io/releng/issue/11356 FEDORA-2023-39a28215e1 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-39a28215e1 FEDORA-2023-77e17cf235 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-77e17cf235 (In reply to fedora.dm0 from comment #3) > I've updated this package to re-enable tests by default and skip the broken > one and to replace the patch with the automatic format. Great, looks good to me. Thanks! FEDORA-2023-77e17cf235 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-77e17cf235 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-77e17cf235 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-39a28215e1 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-39a28215e1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-77e17cf235 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-39a28215e1 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |