Bug 2181523

Summary:	jupterlab Requires /usr/bin/node
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	jupyterlab	Assignee:	Lumír Balhar <lbalhar>
Status:	CLOSED ERRATA	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lbalhar, python-packagers-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	jupyterlab-4.0.0~b0-4.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-03-29 16:28:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2023-03-24 11:43:29 UTC

Description of problem:
jupterlab Requires /usr/bin/node

If I understand this app correctly, it runs JavaScript in my browser, not by nodejs. However, there are executable files with /usr/bin/node shebangs in the bundled javascript directory and they pull in nodejs with jupyterlab, which is likely not needed.

Version-Release number of selected component: jupyterlab-4.0.0~a37-1.fc39.noarch


How reproducible:
$ repoquery -q --repo=rawhide --requires jupyterlab | grep node
/usr/bin/node


Additional info:
I believe this is caused by /usr/lib/python3.11/site-packages/jupyterlab/staging/yarn.js

How is this file used? Can the dependency be avoided?

Comment 1 Lumír Balhar 2023-03-24 16:07:58 UTC

It seems that it can be avoided. If I remove shebang from yarn.js and the nodejs is not installed, lab generates this warning:

[W 2023-03-24 16:02:47.382 LabApp] Could not determine jupyterlab build status without nodejs

but it seems to have no impact on the functionalities at all. I'll open a PR.

Comment 2 Lumír Balhar 2023-03-27 11:24:59 UTC

https://src.fedoraproject.org/rpms/jupyterlab/pull-request/3

Comment 3 Fedora Update System 2023-03-29 16:13:43 UTC

FEDORA-2023-ec3158bfa2 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ec3158bfa2

Comment 4 Fedora Update System 2023-03-29 16:28:25 UTC

FEDORA-2023-ec3158bfa2 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.