Bug 218183
Summary: | Review Request: offlineimap - sync local and remote mail repositories via imap | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Till Maas <opensource> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dodji, pbonzini, yatiohi |
Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://software.complete.org/offlineimap/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-12-03 18:22:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Till Maas
2006-12-02 21:05:50 UTC
I will review this certainly later.... Well, would you check the dependency for this package? For example: -------------------------------------- /usr/lib/python2.4/site-packages/offlineimap/ui/Tk.py:import tkFont -------------------------------------- This means this package requires tkinter. For me tkinter is required only by python-imaging and comix (both in Extras). tkinter is only required when someone wants to use the tkinter user interface of offlineimap, but there are five other user interfaces that work well. So it is more an optional requirement, which is not supported by rpm afaik. Well, then other dependencies are okay? P.S. 'other' means that: ------------------------------------------------------ [tasaka1@localhost SPECS]$ ( for f in /usr/bin/offlineimap `rpm -ql offlineimap | grep py$` ; do grep 'import ' $f ; done ) | sed -e 's|^[ \t]*||' | sort | uniq from Base import BaseFolder from Base import BaseRepository from Blinkenlights import BlinkenBase from ConfigParser import ConfigParser from IMAP import IMAPFolder from Queue import Queue from ScrolledText import ScrolledText from StringIO import StringIO from Tkinter import * from UIBase import UIBase from __future__ import nested_scopes from copy import copy from getopt import getopt from getpass import getpass from mailbox import Maildir from offlineimap import CustomConfig from offlineimap import folder from offlineimap import folder, imaputil from offlineimap import folder, imaputil, imapserver from offlineimap import imaplib, imapserver, repository, folder, mbnames, threadutil, version from offlineimap import imaplib, imapserver, repository, folder, mbnames, threadutil, version, syncmaster, accounts from offlineimap import imaplib, imaputil, threadutil from offlineimap import imaputil from offlineimap import imaputil, imaplib from offlineimap import init from offlineimap import threadutil from offlineimap import threadutil, mbnames, CustomConfig from offlineimap import threadutil, version from offlineimap import version, threadutil from offlineimap.CustomConfig import CustomConfigParser from offlineimap.accounts import SyncableAccount from offlineimap.folder.UIDMaps import MappedIMAPFolder from offlineimap.localeval import LocalEval from offlineimap.repository.IMAP import IMAPRepository, MappedIMAPRepository from offlineimap.repository.Maildir import MaildirRepository from offlineimap.threadutil import ExitNotifyThread from offlineimap.threadutil import InstanceLimitedThread from offlineimap.threadutil import InstanceLimitedThread, ExitNotifyThread from offlineimap.threadutil import MultiLock from offlineimap.ui import UIBase from offlineimap.ui import UIBase # for getglobalui() from offlineimap.ui.Blinkenlights import BlinkenBase from offlineimap.ui.UIBase import UIBase from offlineimap.version import versionstr from stat import * from threading import * from threading import Event from threading import Lock import Base, IMAP, Maildir, LocalStatus import Curses import Noninteractive import TTY import Tk import Tkinter import UIBase, Blinkenlights import binascii, re, socket, time, random, sys, os import curses import curses, curses.panel, curses.textpad, curses.wrapper import detector import errno import fcntl import getopt, getpass import imp import offlineimap.accounts import offlineimap.repository.Base, offlineimap.repository.LocalStatus import offlineimap.ui import offlineimap.version import os import os, re import os, threading import os.path import os.path, os, re, time, socket, md5 import os.path, re import profile import re # for folderfilter import re, os, os.path, offlineimap, sys import re, string, types import re, time, sys, traceback, threading, thread import re, types, os import rfc822, time, string, random, binascii, re import select, sys import sys import sys, time import sys, traceback, thread import thread import thread, hmac, os import thread, time, sys, os, signal, time import thread, traceback, time, threading import threading import time import tkFont import traceback ------------------------------------------------------ The other imports except Tk which is needed for the user interface are either from offlineimap modules or modules in the python package which is requirement is added by rpm. Btw. is there any tool that can help one with this dependency checking? Well, then this package meets http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines ---------------------------------------------- This package (offlineimap) is APPROVED by me. ---------------------------------------------- By the way, it seems that 4.0.16 is released. (In reply to comment #6) > Btw. is there any tool that can help one with this dependency > checking? I have several applications packaged which uses python, at which time I always had to check python-related dependency manually... In fact I really want that tool. imported and successfully built as 22865 for devel - version bump - added one more %%{version} to Source0 - added FAQ.html, todo to %%doc - added debian/changelog as ChangeLog to %%doc Forgot to thank you for this fast review :-) And I just noticed that the Tk Interface probably will be removed in 4.1.0 so even this optional dependency will go away soon. Package Change Request ====================== Package Name: offlineimap New Branches: el6 Owners: bonzini Git done (by process-git-requests). Package Change Request ====================== Package Name: offlineimap New Branches: el7 Owners: dodji Git done (by process-git-requests). |