Bug 2181994

Summary: Review Request: python-urltools - Some functions to parse and normalize URLs
Product: [Fedora] Fedora Reporter: Steve Traylen <steve.traylen>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: blin, djw8605, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-13 14:22:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2181686    
Attachments:
Description Flags
The .spec file difference from Copr build 5711343 to 5725506 none

Description Steve Traylen 2023-03-27 07:54:45 UTC 
Spec URL: http://cern.ch/straylen/rpms/python-urltools/python-urltools.spec
SRPM URL: http://cern.ch/straylen/rpms/python-urltools/python-urltools-0.4.0-1.fc39.src.rpm
Description: Some functions to parse and normalize URLs
Fedora Account System Username: stevetraylen
Comment 1 Steve Traylen 2023-03-28 16:55:32 UTC 
I don't like the way when you import this module it down loads a file.
I think it will be better to just ship the file?

The .tld file will nearly never change anyway.
Comment 2 Steve Traylen 2023-03-29 06:44:20 UTC 
* Much happier, I learnt that the package:

   $ rpm -ql publicsuffix-list
   /usr/share/publicsuffix/effective_tld_names.dat

which is a much better source for effective_tld_names.dat.

* Also converted to pyproject macros which I could not get to work before.
Comment 3 Steve Traylen 2023-03-29 06:44:40 UTC 
[fedora-review-service-build]
Comment 4 Jakub Kadlčík 2023-03-29 06:51:16 UTC 
Created attachment 1954349 [details]
The .spec file difference from Copr build 5711343 to 5725506
Comment 5 Derek 2023-09-13 14:22:59 UTC 
python-urltools is not used by any other packages, removing this request.