Bug 2181999

Summary: kubevirt-plugin (now kubevirt-console-plugin) ignores node placement configuration
Product: Container Native Virtualization (CNV) Reporter: Simone Tiraboschi <stirabos>
Component: InstallationAssignee: Dharmit Shah <dshah>
Status: CLOSED ERRATA QA Contact: SATHEESARAN <sasundar>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.13.0CC: gveitmic, kmajcher, sasundar, stirabos
Target Milestone: ---   
Target Release: 4.13.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.13.3.rhel9-47 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-16 14:09:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Simone Tiraboschi 2023-03-27 08:10:14 UTC
Description of problem:
Something like:

apiVersion: hco.kubevirt.io/v1beta1
kind: HyperConverged
metadata:
  name: kubevirt-hyperconverged
  namespace: openshift-cnv
spec:
  infra:
    nodePlacement:
      nodeSelector:
        node-role.kubernetes.io/infra: ''
  workloads:
    nodePlacement:
      nodeSelector:
        node-role.kubernetes.io/worker: ''

is not properly propagated down to kubevirt-plugin (now kubevirt-console-plugin) deployment

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. configure HCO CR as for the suggested configuration
2. check the placement of kubevirt-plugin (now kubevirt-console-plugin)
3.

Actual results:
kubevirt-console-plugin is not scheduled on infra nodes

Expected results:
kubevirt-console-plugin is not scheduled on infra nodes

Additional info:

Comment 1 Krzysztof Majcher 2023-05-09 13:00:17 UTC
Manually updating the pr link: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/2319

Comment 2 Simone Tiraboschi 2023-07-03 10:07:19 UTC
Postponing to 4.13.3

Comment 3 Simone Tiraboschi 2023-07-05 09:44:38 UTC
Waiting for the first build for v4.13.3

Comment 5 SATHEESARAN 2023-07-26 11:29:30 UTC
kubevirt-console-plugin pod doesn't run in the expected node.
'nodeSelector' information is not propagated from hco to kubevirt-console-plugin deployment.

As discussed with Dharmit (developer), this issue looks strange and analyzing the possibility
of fix not included in the build. So waiting on Dharmit for more information.

Overall, as the expected result is not met. So marking this bug as FAILED

Comment 6 Dharmit Shah 2023-08-07 11:30:08 UTC
> As discussed with Dharmit (developer), this issue looks strange and
> analyzing the possibility
> of fix not included in the build. So waiting on Dharmit for more information.


Issue was there was a bug in the bug fix! Testing this the same way as earlier should suffice in terms of how to verify things.

Comment 7 SATHEESARAN 2023-08-08 19:22:06 UTC
Verified with CNV v4.13.3.rhel9-230 and OCP 4.13.6

The following steps are used for verification.
1. Install 'OpenShift Virtualization' operator from OpenShift Webconsole
2. Update one of the worker node as 'infra' node using '#oc edit node <worker>'
3. Create 'OpenShift Virtualization' deployment (i.e) hyperconverged, and in that yaml view
update 'hco.spec.infra' as follows:
<snip>
  infra:
    nodePlacement:
      nodeSelector:
        node-role.kubernetes.io/infra: ""
</snip>
4. Create 'hyperconverged' and wait for the object to be created.
5. Validate that 'kubevirt-console-plugin' run on the node designated as 'infra'

Comment 15 errata-xmlrpc 2023-08-16 14:09:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.13.3 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:4664