Bug 2182063

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5712140
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182063-python-immutabledict/fedora-rawhide-x86_64/05712140-python-immutabledict/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The License tag reflects the package contents and uses the correct identifiers.


- [!] The license text is included and marked with %license.


- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).


- [!] There are no relevant rpmlint errors.

> python3-immutabledict.noarch: W: no-documentation

Please include the README in the package.


- [x] The package runs tests in %check.

Yes, but if you're going to add a check bcond, then you should also conditionalize the `BuildRequires: pytest`.

I'd change

```
BuildRequires:  pytest
```

to

```
%if %{with check}
BuildRequires:  python3-pytest
%endif
```


- [!] The latest version is packaged or packaging an earlier version is justified.

The latest version is 2.2.4.

- [!] Packager considers avoiding confusing `%foo_name` macros. (Not a blocker)

I'd suggest removing

```
%global modname immutabledict
```

and just use the literal value everywhere.


- [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name
- [-] Applications: A `python3-` prefix is not used
- [x] The pyproject macros are used
- [x] There are no bundled libraries


- [!] The package complies with the Python and general Packaging Guidelines.

The missing license texts are a problem.

Thank you for taking a look! I expected the license to be added automatically by %{pyproject_files}, but did not check to make sure. It’s now fixed, together with your other suggestions :)

Spec URL: https://v02460.fedorapeople.org/python-immutabledict.spec
SRPM URL: https://v02460.fedorapeople.org/python-immutabledict-2.2.4-1.fc39.src.rpm

Created attachment 1963822 [details]
The .spec file difference from Copr build 5712140 to 5908122

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5908122
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182063-python-immutabledict/fedora-rawhide-x86_64/05908122-python-immutabledict/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The license text is included and marked with %license.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).

- [x] There are no relevant rpmlint errors.

- [x] The package runs tests in %check.

Yes, but please depend on "python3-pytest" instead of "pytest". "python3-pytest" is the canonical name.

- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] Packager considers avoiding confusing `%foo_name` macros. (Not a blocker)
- [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name
- [-] Applications: A `python3-` prefix is not used
- [x] The pyproject macros are used
- [x] There are no bundled libraries
- [x] The package complies with the Python and general Packaging Guidelines.

Package approved! Thanks. On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish.

Thanks!

> Yes, but please depend on "python3-pytest" instead of "pytest". "python3-pytest" is the canonical name.

This can be done on import.

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-immutabledict

FEDORA-2023-e321313ed3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e321313ed3

FEDORA-2023-e321313ed3 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.