Bug 2182207

Summary: Review Request: nginx-mod-modsecurity - ModSecurity v3 nginx connector
Product: [Fedora] Fedora Reporter: Mikel Olasagasti Uranga <mikel>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/SpiderLabs/ModSecurity-nginx
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-11 14:38:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 5714850 to 5740165 none

Description Mikel Olasagasti Uranga 2023-03-27 22:10:23 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/nginx-mod-modsecurity.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/nginx-mod-modsecurity-1.0.3-1.fc37.src.rpm
Description: The ModSecurity-nginx connector is the connection point between nginx and
libmodsecurity (ModSecurity v3). Said another way, this project provides a
communication channel between nginx and libmodsecurity. This connector is
required to use LibModSecurity with nginx.

The ModSecurity-nginx connector takes the form of an nginx module. The module
simply serves as a layer of communication between nginx and ModSecurity

Fedora Account System Username: mikelo2

Comment 1 Jakub Kadlčík 2023-03-27 22:17:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5714850
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182207-nginx-mod-modsecurity/fedora-rawhide-x86_64/05714850-nginx-mod-modsecurity/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jakub Kadlčík 2023-04-03 22:42:36 UTC
Created attachment 1955619 [details]
The .spec file difference from Copr build 5714850 to 5740165

Comment 4 Jakub Kadlčík 2023-04-03 22:42:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5740165
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182207-nginx-mod-modsecurity/fedora-rawhide-x86_64/05740165-nginx-mod-modsecurity/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Neal Gompa 2023-04-11 14:07:20 UTC
Review notes:

* Package builds and installs
* Package naming is good
* Licensing is correct and license file is correctly installed
* No serious rpmlint issues

Note: A runtime dependency on nginx-filesystem is missing, please add on import.

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2023-04-11 14:14:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/nginx-mod-modsecurity

Comment 7 Fedora Update System 2023-04-11 14:37:14 UTC
FEDORA-2023-872e471b7c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-872e471b7c

Comment 8 Fedora Update System 2023-04-11 14:38:47 UTC
FEDORA-2023-872e471b7c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.