Bug 218226 (pear-DG-MDB2)

Summary: Review Request: php-pear-Structures-DataGrid-DataSource-MDB2 - DataSource driver using PEAR::MDB2 and an SQL query
Product: [Fedora] Fedora Reporter: Christopher Stone <chris.stone>
Component: Package ReviewAssignee: Michał Bentkowski <mr.ecik>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: wtogami: fedora-cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-12-27 23:43:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Christopher Stone 2006-12-03 21:43:20 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-MDB2.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Structures-DataGrid-DataSource-MDB2-0.1.2-1.src.rpm

Description:
This is a DataSource driver for Structures_DataGrid using PEAR::MDB2 and an
SQL query.

Comment 1 Michał Bentkowski 2006-12-27 18:06:48 UTC
MUST items:
 * rpmlint output:
W: php-pear-Structures-DataGrid-DataSource-MDB2 filename-too-long-for-joliet 
php-pear-Structures-DataGrid-DataSource-MDB2-0.1.2-1.fc7.noarch.rpm
 * package is named wel
 * spec file name is good
 * package meets Packaging Guidelines
 * package is licensed with a PHP open-source compatible license
 * License field in spec file matches actual license 
 * license file is included in %doc
 * md5sums are matching (2c31b48d18bc610cae3f91b86b822932)
 * BuildRequires listed well
 * no locales
 * proper %post and %postun sections
 * not relocatable
 * package owns directories well
 * no duplicates in %files
 * %files section includes %defattr 
 * proper %clean section
 * macros used well

Another easy to review package ;)
Approved!

Comment 2 Christopher Stone 2006-12-27 23:43:46 UTC
- srpm checked into cvs
- entry added to owners.list
- built for devel
- branch requested for fc5/6

Thanks for the review!

Comment 3 Christopher Stone 2007-05-06 23:17:17 UTC
Package Change Request
======================
Package Name: php-pear-Structures-DataGrid-DataSource-MDB2
New Branches: EL-5