Bug 2182358

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5716327
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182358-unzboot/fedora-rawhide-x86_64/05716327-unzboot/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: 
 - https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fedora-rawhide-x86_64/05677525-unzboot/unzboot.spec

SRPM URL: 
 - https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fedora-rawhide-x86_64/05677525-unzboot/unzboot-0.1-1.git3285b558.fc39.src.rpm

Created attachment 1954230 [details]
The .spec file difference from Copr build 5716327 to 5718574

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5718574
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182358-unzboot/fedora-rawhide-x86_64/05718574-unzboot/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Everything looks to me, the only comment I've is that the Fedora package policy
has a very precise naming for packages that are built from git snapshots rather
than released tarballs versions. And the package doesn't follow the guidelines:

https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

In short, you need to have something like following diff to your current SPEC
(I've not tested this though so there may be some typos):

diff --git a/unzboot.spec b/unzboot.spec
index 7e845fee4575..9dd816eab379 100644
--- a/unzboot.spec
+++ b/unzboot.spec
@@ -1,15 +1,19 @@
-%global gitversion 3285b558  
+%global commit 3285b558529b862391d27afe098368d6f8dda09e
+%global shortcommit %(c=%{commit}; echo ${c:0:7})
+%global commitdate 20230318
 
 Name:          unzboot
-Version:       0.1
-Release:       1.git%{gitversion}%{?dist}
+Version:       0.1~git.%{commitdate}.%{shortcommit}
+Release:       1%{?dist}
 
 Summary:       Extracts a kernel vmlinuz image from a EFI application.
 License:       MIT
 
-# git snapshot.  to recreate, run:
-# ./make-git-snapshot.sh `cat commitid`
-Source0:       unzboot-%{gitversion}.tar.xz
+# Upstream is still under development so they are not tagging releases
+# yet. Use the following to do a rebase to a new snapshot:
+#
+# git archive --format=tar --prefix=${name}-${shortcommit}/ ${shortcommit} | xz > ${name}-${shortcommit}.tar.xz
+Source0:       %{name}-%{shortcommit}.tar.xz
 
 BuildRequires: gcc
 BuildRequires: glib2-devel
@@ -22,7 +26,7 @@ a EFI application that carries the actual kernel image in
 compressed form.
 
 %prep
-%setup -q -n %{name}-%{gitversion}
+%autosetup -n %{name}-%{shortcommit}
 %build
 %meson
 %meson_build
@@ -37,5 +41,5 @@ compressed form.
 %{_bindir}/unzboot
 
 %changelog
-* Sat Mar 18 2023 Enric Balletbo i Serra <eballetbo> - 0.1-1.git3285b558 
+* Sat Mar 18 2023 Enric Balletbo i Serra <eballetbo> - 0.1~git.20210928.e00149f-1
 - initial unzboot spec

Spec URL: 
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fedora-rawhide-x86_64/05741262-unzboot/unzboot.spec

SRPM URL:
https://download.copr.fedorainfracloud.org/results/eballetbo/chromebooks/fedora-rawhide-x86_64/05741262-unzboot/unzboot-0.1~git.20230318.3285b55-1.fc39.src.rpm

Thanks Javier for the review, just posted a new package following the guidelines for packages that are built from git snapshots.

Created attachment 1955673 [details]
The .spec file difference from Copr build 5718574 to 5741285

Copr build:
https://copr.fedorainfracloud.org/coprs/build/5741285
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182358-unzboot/fedora-rawhide-x86_64/05741285-unzboot/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks good to me now.

The Pagure repository was created at https://src.fedoraproject.org/rpms/unzboot

Enric, if you are not going to build this package for older Fedoras, close this bug.