Bug 2182479
| Summary: | Review Request: rust-itoap - Even faster functions for printing integers with decimal format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Maxwell G <maxwell> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/itoap | ||
| Whiteboard: | |||
| Fixed In Version: | rust-itoap-1.0.1-2.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-03-28 23:16:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Maxwell G
2023-03-28 19:10:24 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5718907 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182479-rust-itoap/fedora-rawhide-x86_64/05718907-rust-itoap/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me, though you might want to explicitly exclude some files from the package (i.e. by generating this patch with "rust2rpm -p"): ``` --- itoap-1.0.1/Cargo.toml 2021-02-18T16:50:24+00:00 +++ itoap-1.0.1/Cargo.toml 2023-03-28T19:56:56.117524+00:00 @@ -21,6 +21,7 @@ categories = ["value-formatting"] license = "MIT" repository = "https://github.com/Kogia-sima/itoap" +exclude = ["/bench.png", "/codecov.yml", "/rustfmt.toml"] [package.metadata.docs.rs] all-features = true rustdoc-args = ["--cfg", "docsrs"] ``` A patch like this should also be acceptable by the upstream project, since these files are only useful as docs or for upstream development / CI. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification ("MIT") and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-itoap FEDORA-2023-dafc5d121a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-dafc5d121a FEDORA-2023-dafc5d121a has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-22577f9c11 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-22577f9c11 FEDORA-2023-cfb6d62fad has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cfb6d62fad FEDORA-2023-8a4f34d8ed has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8a4f34d8ed FEDORA-2023-cfb6d62fad has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-cfb6d62fad See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-22577f9c11 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-22577f9c11` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-22577f9c11 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8a4f34d8ed has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8a4f34d8ed` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8a4f34d8ed See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-22577f9c11 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-8a4f34d8ed has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-cfb6d62fad has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |