Bug 2182814

Summary: Review Request: python-hiredis - Python extension that wraps protocol parsing code in hiredis
Product: [Fedora] Fedora Reporter: Kai A. Hiller <V02460>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, topazus
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/redis/hiredis-py
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-06-12 00:45:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2141154    
Bug Blocks: 201449, 1886035    

Description Kai A. Hiller 2023-03-29 18:03:23 UTC
Spec URL: https://v02460.fedorapeople.org/python-hiredis.spec
SRPM URL: https://v02460.fedorapeople.org/python-hiredis-2.0.0-1.fc39.src.rpm
Description: Python extension that wraps protocol parsing code in hiredis. It primarily speeds up parsing of multi bulk replies.
Fedora Account System Username: v02460

Note: Upstream python-hiredis is at version 2.2.2, which requires hiredis v1.1; Fedora is still at hiredis v1.0, so this review request is for python-hiredis v2.0.0.

Comment 1 Jakub Kadlčík 2023-03-29 18:09:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5727388
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2182814-python-hiredis/fedora-rawhide-x86_64/05727388-python-hiredis/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Felix Wang 2023-05-11 01:39:10 UTC
The upstream of hiredis has updated to 2.2.3. Can you update to this latest release?

Comment 3 Felix Wang 2023-05-11 01:40:36 UTC
(In reply to Felix Wang from comment #2)
> The upstream of hiredis has updated to 2.2.3. Can you update to this latest
> release?

Oh, I see the note of the initial comment.

Comment 4 Felix Wang 2023-05-11 02:04:36 UTC
Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

> Requires:       hiredis >= 1.0 with hiredis < 1.1

The dependency version requirements of hiredis should be changed to `Requires:       hiredis >= 1.0, hiredis < 1.1`, which maybe change the installation error, if you want to set this requirement.

Comment 5 Package Review 2024-05-11 00:45:31 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Package Review 2025-05-12 00:45:21 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 7 Package Review 2025-06-12 00:45:28 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.