Bug 2182898

We will need backports for common, then create a new version of common, and then backport to Podman v4.4.1-rhel branch and also vendor the updated common in.

Fixed with https://github.com/containers/common/pull/1387, which is part of c/common v0.51.2 and Podman v4.4.1-rhel.  Jindrich, please take the top of that Podman branch for this.

Setting to Post and assigning to Jindrich for any further packaging or BZ needs.

Tom, this is a c/common PR, do you happen to have a PR against podman?

Ooops, actually it went in for two other BZs too.  https://github.com/containers/podman/pull/18006

The BZ's for that were: https://bugzilla.redhat.com/show_bug.cgi?id=2183601 and https://bugzilla.redhat.com/show_bug.cgi?id=2183602  but the patch also addresses this.

Thanks Tom! This is actually good news. The functional part is already applied. Only this part of https://github.com/containers/common/pull/1387 is missing:

@@ -666,6 +666,8 @@ var _ = Describe("Config", func() {
 			testNetwork, err := libpodNet.NetworkInspect("test-network")
 			Expect(err).To(BeNil())
 			Expect(testNetwork.NetworkDNSServers).To(Equal([]string{"8.8.8.8", "3.3.3.3", "7.7.7.7"}))
+			err = libpodNet.NetworkUpdate("test-network", types.NetworkUpdateOptions{AddDNSServers: []string{"fake"}})
+			Expect(err).To(HaveOccurred())
 		})
 
 		It("update NetworkDNSServers RemoveDNSServers", func() {
@@ -690,6 +692,8 @@ var _ = Describe("Config", func() {
 			testNetwork, err := libpodNet.NetworkInspect("test-network")
 			Expect(err).To(BeNil())
 			Expect(testNetwork.NetworkDNSServers).To(Equal([]string{"8.8.8.8"}))
+			err = libpodNet.NetworkUpdate("test-network", types.NetworkUpdateOptions{RemoveDNSServers: []string{"fake"}})
+			Expect(err).To(HaveOccurred())
 		})
 
 		It("update NetworkDNSServers Add and Remove DNSServers", func() {

Which led me to a conclusion it's not applied. I will now go ahead do the bugzilla paperwork :)

The hunk noted in comment #6 is for libnetwork/netavark/config_test.go - assuming we don't need that one?

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (podman bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2620