Bug 2183177

Summary:	[RDR] ocs-operator should automatically set spec.network.multiClusterService.Enabled: true for RDR cluster
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Pratik Surve <prsurve>
Component:	odf-dr	Assignee:	umanga <uchapaga>
odf-dr sub component:	multicluster-orchestrator	QA Contact:	Pratik Surve <prsurve>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	aclewett, ebenahar, kramdoss, kseeger, muagarwa, odf-bz-bot, uchapaga
Version:	4.13
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.13.0-170	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-21 21:27:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pratik Surve 2023-03-30 13:54:38 UTC

Description of problem (please be detailed as possible and provide log
snippests):

[RDR] ocs-operator should automatically set spec.network.multiClusterService.Enabled: true for RDR cluster

Version of all relevant components (if applicable):

OCP version:- 4.13.0-0.nightly-2023-03-28-014156
ODF version:- 4.13.0-121
CEPH version:- ceph version 17.2.5-1342.el9cp (ed07851f2c5b8d3dccadf079402f86a67cb7d3e5) quincy (stable)


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?


Is there any workaround available to the best of your knowledge?


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?


Can this issue reproducible?


Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1.
2.
3.


Actual results:

When testing RDR with overlapping ip user has to manually add spec.network.multiClusterService.Enabled: true  to the storage cluster

Expected results:

manually setup should be automated 

Additional info:

Comment 3 Malay Kumar parida 2023-04-04 09:07:07 UTC

The relevant discussion for the BZ is happening here 
https://chat.google.com/room/AAAAqWkMm2s/CMVr74gcmbM

Comment 4 umanga 2023-04-05 05:16:33 UTC

ocs-operator will never set `spec.network.multiClusterService.Enabled: true`. This is a user provided configuration.
Since this needs to be set only for Regional DR, and only when overlapping CIDRs are used, we do not want to make this a default.

Since multicluster-orchestrator aims to automate ODF configuration for DR, we'll try to resolve this. The fix will be in 2 parts:
1. If user sets `spec.network.multiClusterService.Enabled: true`, we will not overwrite it. This will unblock testing.
2. We will try to detect overlapping CIDRs and set this flag automatically. This is a new feature and not a simple bug fix. So,
this might not make it in time for 4.13.0.

Comment 7 umanga 2023-04-05 17:21:18 UTC

Created a separate BZ to track the bug fix: https://bugzilla.redhat.com/show_bug.cgi?id=2184773
This BZ will track development of the automation mentioned in Comment 4.

Comment 8 umanga 2023-04-10 10:47:59 UTC

https://github.com/red-hat-storage/odf-multicluster-orchestrator/pull/160 adds a new field in MirrorPeer to allow users to enable MulticlusterService if required.
We will not automate overlapping CIDR detection. UI will provide an option in multicluster console to opt-in to this feature.

Comment 12 Elad 2023-06-19 06:02:17 UTC

Moving to 4.13.z for verification purposes