Bug 2183331
| Summary: | Review Request: rust-winnow - Byte-oriented, zero-copy, parser combinators library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> | ||||
| Component: | Package Review | Assignee: | Aleksei Bavshin <alebastr89> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | alebastr89, package-review | ||||
| Target Milestone: | --- | Flags: | alebastr89:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/winnow | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-04-03 22:01:34 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2136899 | ||||||
| Attachments: |
|
||||||
|
Description
Fabio Valentini
2023-03-30 21:48:31 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5731286 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183331-rust-winnow/fedora-rawhide-x86_64/05731286-rust-winnow/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good with minor comments. > # * missing dev-dependencies: circular, snapbox, term-transcript You can run `%cargo_test -- --doc` and `%cargo_test -- --lib` even without the listed packages. In fact, most of dev-dependencies are there only for examples. And for `debug`... > %package -n %{name}+unstable-doc-devel Does this feature have any use other than in docs.rs documentation? Well, it's not harmful either so IMO it's fine to leave it. (In reply to Aleksei Bavshin from comment #2) > Looks good with minor comments. > > > # * missing dev-dependencies: circular, snapbox, term-transcript > > You can run `%cargo_test -- --doc` and `%cargo_test -- --lib` even without > the listed packages. In fact, most of dev-dependencies are there only for > examples. And for `debug`... Huh, you're right. I've removed those dependencies and added running unit and doc tests. > > %package -n %{name}+unstable-doc-devel > > Does this feature have any use other than in docs.rs documentation? Well, > it's not harmful either so IMO it's fine to leave it. Right, it's not harmful since it doesn't pull in any extra dependencies ... Updated files behind the same URLs. [fedora-review-service-build] Created attachment 1955402 [details]
The .spec file difference from Copr build 5731286 to 5738121
Copr build: https://copr.fedorainfracloud.org/coprs/build/5738121 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2183331-rust-winnow/fedora-rawhide-x86_64/05738121-rust-winnow/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good. Approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-winnow FEDORA-2023-819f0f3a80 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-819f0f3a80 FEDORA-2023-819f0f3a80 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |