Bug 2183392

Summary:	pyp2rpm fails to build with the latest setuptools version
Product:	[Fedora] Fedora	Reporter:	Charalampos Stratakis <cstratak>
Component:	pyp2rpm	Assignee:	Gordon Messmer <gordon.messmer>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	gordon.messmer, kevin, mhroncok, python-packagers-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pyp2rpm-3.3.9-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-13 01:13:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2144132

Description Charalampos Stratakis 2023-03-31 00:11:48 UTC

pyp2rpm fails to build with the latest setuptools version.

This report is automated and not very verbose, but we'll try to get back here with details.

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/cstratak/setuptools-67.5.1/fedora-rawhide-x86_64/05722224-pyp2rpm/

For all our attempts to build pyp2rpm with the latest setuptools, see:
https://copr.fedorainfracloud.org/coprs/cstratak/setuptools-67.5.1/package/pyp2rpm/

Let us know here if you have any questions.

Comment 1 Miro Hrončok 2023-03-31 09:30:22 UTC

FAILED tests/test_dependency_parser.py::TestDependencyParser::test_dependency_to_rpm[nb2plots>0+unknown-True-True-expected10]


self = <[AttributeError("'Requirement' object has no attribute 'name'") raised in repr()] Requirement object at 0x7f4227418050>
requirement_string = 'nb2plots>0+unknown'

    def __init__(self, requirement_string: str) -> None:
        try:
            parsed = parse_requirement(requirement_string)
        except ParserSyntaxError as e:
>           raise InvalidRequirement(str(e)) from e
E           pkg_resources.extern.packaging.requirements.InvalidRequirement: Expected end or semicolon (after version specifier)
E               nb2plots>0+unknown
E                       ~~^

/usr/lib/python3.11/site-packages/pkg_resources/_vendor/packaging/requirements.py:37: InvalidRequirement

Comment 2 Gordon Messmer 2023-04-07 02:11:40 UTC

The version now in rawhide should work.  Do I need to take any additional steps to close this bug?

Comment 3 Charalampos Stratakis 2023-04-13 01:13:19 UTC

Thank you for the fix!