Bug 218367
Summary: | Review Request: compat-guile - Guile compatibility package | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gérard Milmeister <gemi> |
Component: | Package Review | Assignee: | Chitlesh GOORAH <chitlesh> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mtasaka |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-01-06 10:40:59 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Gérard Milmeister
2006-12-04 21:24:25 UTC
I'll review this. Btw, I need it too for geda packages. Good job Gérard :) #001 Parallel builds
%{?_smp_mflags} missing on make
#002 typo
Line 83
# Ouch! guile forgets to set it's onw shared lib path to use shared uninstalled
>>>> own
#003 cleanups ?
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
$RPM_BUILD_ROOT isn't defined up in the spec file ?
Is it useful ?
#004: missing url tag
#005: macro-in-%changelog
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog file
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog post
W: compat-guile macro-in-%changelog postun
W: compat-guile macro-in-%changelog attr
W: compat-guile macro-in-%changelog post
W: compat-guile macro-in-%changelog description
W: compat-guile macro-in-%changelog files
W: compat-guile macro-in-%changelog postun
W: compat-guile macro-in-%changelog PACKAGE_VERSION
W: compat-guile macro-in-%changelog attr
add a % more in front for those macros
#007 mixed-use-of-spaces-and-tabs
W: compat-guile mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 86)
Other Rpmlints issues:
$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/compat-libguile-1.6.7-1.i386.rpm
dangling-relative-symlink
W: compat-libguile dangling-relative-symlink /usr/share/guile/slib ../../share/slib
E: compat-libguile non-standard-executable-perm /usr/share/guile/1.6/scripts/c2x
0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/scan-md-module 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/slurp 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/make-module-catalog 0555
E: compat-libguile non-standard-executable-perm
/usr/share/guile/1.6/scripts/PROGRAM2 0555
$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/compat-libguile-devel-1.6.7-1.i386.rpm
W: compat-libguile-devel no-dependency-on compat-libguile
Fix those, I'll approve it, However it builds successfully under mock.
I have fixed most of the above. * The symlink to slib does not dangle anymore oncen the package is installed, since the slib package is required. * Most warnings about the macros in changelog are spurious, since they are not macros, but section headers. They appear correctly in the changelog of the package. http://math.ifi.unizh.ch/fedora/6/i386/SRPMS.gemi/compat-guile-1.6.7-2.src.rpm TeXmacs, the package for which I needed compat-guile, supports in its new version guile 1.8, so my interest in a compat-guile package has all but vanished. It would be better if someone who needs it takes up the request. Chitlesh, that you want a new "reviewer" means you want to take over this package? Yes, I'll take over this package. (In reply to comment #6) > Yes, I'll take over this package. Well, then please * once close this bug as NOTABUG and make this report block bug 201449 * request a new review request (of which the reporter is you) * then, change the status of this bug from NOTABUG to DUPLICATE of your new review request (this time I can notice that this bug is marked as a duplicate) Then I will review your review request. http://fedoraproject.org/wiki/Extras/Policy/StalledReviews *** This bug has been marked as a duplicate of 221698 *** |