Bug 2183867

Summary:	Review Request: rust-slotmap - Slotmap data structure
Product:	[Fedora] Fedora	Reporter:	Aleksei Bavshin <alebastr89>
Component:	Package Review	Assignee:	Felix Wang <topazus>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review, topazus
Target Milestone:	---	Flags:	topazus: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-slotmap-1.0.6-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-02 14:12:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2082670

Description Aleksei Bavshin 2023-04-02 19:45:16 UTC

Spec URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-slotmap/rust-slotmap.spec
SRPM URL: https://alebastr.fedorapeople.org/rust/alacritty-0.12.0/rust-slotmap/rust-slotmap-1.0.6-1.fc38.src.rpm
Copr: https://copr.fedorainfracloud.org/coprs/alebastr/rust-alacritty/
Description:
Slotmap data structure.

Fedora Account System Username: alebastr

Note: this is a re-review for a package that was retired more than 8 weeks ago

Comment 1 Felix Wang 2023-04-06 09:03:28 UTC

It seems something wrong with automatic Copr build of https://github.com/FrostyX/fedora-review-service, so I use my Copr to test it.

Copr build:
https://copr.fedorainfracloud.org/coprs/topazus/test-review/build/5749856/

review.txt:
https://download.copr.fedorainfracloud.org/results/topazus/test-review/fedora-rawhide-x86_64/05749856-rust-slotmap/fedora-review/review.txt

The spec file was generated with rust2rpm that can simply the review. No issues with license or dependencies, and it built successfully.


> rust-slotmap-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/slotmap-1.0.6/src/lib.rs
> rust-slotmap-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/slotmap-1.0.6/README.md
> rust-slotmap-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/slotmap-1.0.6/RELEASES.md

For the end-of-line-encoding issue, which maybe unimportant, maybe you can find solution if you choose to fix at https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding, or you can contact upstream to fix it later.

For now, I approved it.

Comment 2 Felix Wang 2023-04-06 11:37:08 UTC

Although the rust-slotmap package has marked as dead package (no longer needed) in the latest commit, it still has a maintainer (Fabio Valentini, https://src.fedoraproject.org/user/decathorpe) and it has not been marked as an orphan package, maybe you can contact he to the detailed status of the package, which he may add you as co-maintainer directly.
The similar situation happened with the package of rust-ab_glyph_rasterizer, rust-owned_ttf_parser and rust-arrayref.

ref: https://src.fedoraproject.org/rpms/rust-slotmap

Comment 3 Fabio Valentini 2023-04-06 14:47:31 UTC

I no longer have need of this package, so I am fine with alebastr taking over maintenance.
To be honest, I likely just forgot to "orphan" it when I retired the package from Fedora 37+.

Note that the heuristic for generating the package Summary fails for this package. "Data structure" is not very descriptive, it should probably just be "Slotmap data structure".

Comment 4 Aleksei Bavshin 2023-05-02 14:12:23 UTC

Thanks for the review!

Unretired and built for rawhide (https://bodhi.fedoraproject.org/updates/FEDORA-2023-a92630de84)