Bug 2184137
| Summary: | weak dependencies chain - some strange requirements | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | lejeczek <peljasz> |
| Component: | pass | Assignee: | Peter Georg <peter.georg> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel9 | CC: | amatej, cfergeau, peter.georg, pingou |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-10 17:30:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
lejeczek
2023-04-03 18:01:23 UTC
Your description of problem does not describe any issues concerning pass and you have not provided any further information. Can you please describe which issue you are actually seeing? Note: pass has a weak dependency (recommends) on xclip or wl-clipboard. It *tries* to auto-detect whether you are using X11 or Wayland. This is intended. Your logs indicate that there are issues concerning the dependencies of xorg-x11-server-Xorg. Have you tried installing xorg-x11-server-Xorg directly? Have you tried running "dnf check" to see if there are problems in the packagedb? Problem is what the output of the cmd shows - installing 'pass' fails. No other problems with rpm nor with dnf, everything else installs, removes, etc. okey. Should be easy to replicate - try to install 'pass' on Centos 9 Stream. I am running CentOS Stream 9 and have pass installed. No issues at all. Installing pass fails cause installing one of its (indirect through recommends) dependencies (xorg-x11-server-Xorg) fails to install. Hence I asked you to try to install xorg-x11-server-Xorg directly and see if that fails as well. Can you please verify that? 'xorg-x11-server-Xorg' installs, but why in the name of Jesus & st. Mary 'pass' - even through via deps - would want GUI components at all? It's not of the "regular" dependencies, 'pass' insists on 'weak' ones. (In reply to lejeczek from comment #4) > 'xorg-x11-server-Xorg' installs, but why in the name of Jesus & st. Mary > 'pass' - even through via deps - would want GUI components at all? > It's not of the "regular" dependencies, 'pass' insists on 'weak' ones. pass supports copying the password to the clipboard using either xclip or wl-clipboard. Hence these (acutally one of them depending on your environment) are listed as weak-dependencies. xclip then pulls in xorg-x11-server-Xorg. pass does not insist on weak dependencies. Whether weak dependencies are installed or not depends on your dnf configuration. weak dependencies are skipped if they can not be fulfilled. In your case dependencies are available, and you seem to have configured dnf to install weak dependencies, hence dnf adds the dependencies to the list of packages to be installed. Why dnf fails to properly detect the dependencies of xorg-x11-server-Xorg is the actual question here. However, this is not an issue of pass, but of dnf. It's probably worth opening a bug report against dnf. Nothing we can change on the side of pass. If I might suggest - if possible, if would work for text/ssh-only envs - to split 'pass' into separate cmd-only & GUI packages. If that could work, those with no-gui systems - and there must be plethora since it's Linux - will appreciate a lot. thanks, L. There is no separate 'gui' tool for pass, the main script checks if wl-copy or xclip are available, and if they are, `pass show -c ...` copies the password directly to the relevant clipboard. If you want to skip the install of the GUI packages, you can use `--setopt=install_weak_deps=False` on `yum`/`dnf` commandline. And I agree with Peter that there appears to be a dnf/xorg bug. Or maybe you blocked installation of some xorg related packages? There is a problem in dnf (tracked here: https://bugzilla.redhat.com/show_bug.cgi?id=2185061) but I think the pass spec file could also be improved to take into account lejeczek's use case. The specfile contains: ... Recommends: (wl-clipboard if libwayland-client else xclip) Recommends: (xclip if xorg-x11-server-Xorg else wl-clipboard) ... This works fine if libwayland-client or xorg-x11-server-Xorg is installed but if neither is it kind of recommends both. Maybe you could try just: Recommends: (wl-clipboard if libwayland-client) Recommends: (xclip if xorg-x11-server-Xorg) so that no Recommends is installed if there is no libwayland-client/xorg-x11-server-Xorg. Closing this bug as the reported is issue is actually a libsolv issue as noted in comment https://bugzilla.redhat.com/show_bug.cgi?id=2184137#c8 In addition the improvements suggested by amatej have been implemented in epel9 branch and already submitted to testing (pass-1.7.4-7.el9). A MR to get these changes into rawhide as well has been opened (https://src.fedoraproject.org/rpms/pass/pull-request/5). |