Bug 2184720
| Summary: | Review Request: rust-gdk4-x11-sys - FFI bindings of GDK4 X11 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/gdk4-x11-sys | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-21 20:37:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2184723 | ||
|
Description
Kalev Lember
2023-04-05 13:49:22 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5745873 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184720-rust-gdk4-x11-sys/fedora-rawhide-x86_64/05745873-rust-gdk4-x11-sys/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests for gtk-rs projects are known to be broken) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === I assume that you created a rust2rpm.conf file to add BuildRequires / Requires to the respective subpackages? Make sure to also import that. Thanks for the review! Yes, I created a rust2rpm.conf and have it in local git. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-x11-sys FEDORA-2023-4464813aab has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4464813aab FEDORA-2023-4464813aab has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |