Bug 2184723

Summary: Review Request: rust-gdk4-x11 - Rust bindings of the GDK4 X11 library
Product: [Fedora] Fedora Reporter: Kalev Lember <klember>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/gdk4-x11
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-04-27 11:10:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2184720    
Bug Blocks: 2184729    

Description Kalev Lember 2023-04-05 13:55:48 UTC
Spec URL: https://kalev.fedorapeople.org/rust-gdk4-x11.spec
SRPM URL: https://kalev.fedorapeople.org/rust-gdk4-x11-0.6.3-1.fc39.src.rpm
Description: Rust bindings of the GDK4 X11 library.
Fedora Account System Username: kalev

Comment 1 Jakub Kadlčík 2023-04-05 13:59:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5745884
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184723-rust-gdk4-x11/fedora-rawhide-x86_64/05745884-rust-gdk4-x11/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-04-22 14:22:52 UTC
Similar to 2184722, there seem to be subpackages for features that are missing:

- dox
- egl
- khronos-egl

What's the reason for dropping these? And are you sure you don't need this functionality?

Comment 3 Kalev Lember 2023-04-24 19:35:36 UTC
We are missing some deps - the egl crate at least, if I remember right. I just wanted to get a subset in first and then look at adding more optional features.

Comment 4 Fabio Valentini 2023-04-25 17:10:06 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2023-04-27 10:34:20 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gdk4-x11

Comment 6 Kalev Lember 2023-04-27 10:59:22 UTC
Thanks for the review! Package imported and rawhide build under way.

Comment 7 Fedora Update System 2023-04-27 11:07:26 UTC
FEDORA-2023-b9ef0d74c5 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9ef0d74c5

Comment 8 Fedora Update System 2023-04-27 11:10:09 UTC
FEDORA-2023-b9ef0d74c5 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.