Bug 2184729
| Summary: | Review Request: rust-ashpd - XDG portals wrapper in Rust using zbus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/ashpd | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-02 14:52:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2184722, 2184723 | ||
| Bug Blocks: | |||
|
Description
Kalev Lember
2023-04-05 14:08:24 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5745964 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184729-rust-ashpd/fedora-rawhide-x86_64/05745964-rust-ashpd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Please confirm that these missing subpackages are intentional: - gdk3wayland - gdk3x11 - gtk3 - gtk3_wayland - gtk3_x11 - pipewire - pw - raw-window-handle - raw_handle - wayland - wayland-backend - wayland-client - wayland-protocols It looks like you disabled all backends except gtk4 / gdk4wayland + gdk4x11? If this is intentional, the package is fine, it looks good otherwise. Thanks, Fabio! Yes, I've intentionally disabled these - they are all missing dependencies. Thanks for the confirmation! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - subpackages with missing dependencies are disabled - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === If you have time, I have a few simple Rust packages pending review, it would be great if you could look at one or two of those, maybe #2187762 (rust-zvariant_utils), which blocks the update to the latest version of zbus (which I think might be interesting for you, since ashpd depends on zbus). Nice, thank you for the review! Sure, I can look at those, I'm definitely interested in keeping zbus up to date. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ashpd FEDORA-2023-6feb74a6b8 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6feb74a6b8 FEDORA-2023-6feb74a6b8 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |