Bug 2184737
| Summary: | Review Request: R-discretization - Data Preprocessing, Discretization for Classification | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iztok Fister Jr. <iztok> | ||||
| Component: | Package Review | Assignee: | Iñaki Ucar <i.ucar86> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | i.ucar86, package-review | ||||
| Target Milestone: | --- | Flags: | i.ucar86:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://CRAN.R-project.org/package=%{packname} | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-04-15 02:07:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Iztok Fister Jr.
2023-04-05 14:40:48 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/5746002 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184737-R-discretization/fedora-rawhide-x86_64/05746002-R-discretization/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The package does not require testthat for checks. Please remove those bits. Relevant issues: > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0: > https://CRAN.R-project.org/package=discretization&version=1.0.1.1#/discretization_1.0-1.1.tar.gz Note that you should use %{ver} instead of %{version} in the URL. > R-discretization.noarch: W: invalid-license GPL See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > R-discretization.noarch: E: description-line-too-long be grouped in terms of top-down or bottom-up, implementing the discretization algorithms. See https://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-long Thanks. Fixed now. Changes: https://github.com/firefly-cpp/rpm-reviews/commit/79a135ac347ea828149ffe809e4863571038dd5f Note that: - GPL v2 is also allowed - Identifiers from the third column are legacy ones. SPDX identifiers are in the first column of the list. So the license tag should be: GPL-2.0-or-later Also, please always provide new Spec URL and SRPM URL for any change, so that a new check is automatically triggered. SPEC: https://raw.githubusercontent.com/firefly-cpp/rpm-reviews/main/R-discretization.spec SRPM: https://github.com/firefly-cpp/rpm-reviews/raw/main/R-discretization-1.0.1.1-1.fc37.src.rpm Thanks again for your quick response. Created attachment 1955948 [details]
The .spec file difference from Copr build 5746002 to 5746716
Copr build: https://copr.fedorainfracloud.org/coprs/build/5746716 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2184737-R-discretization/fedora-rawhide-x86_64/05746716-R-discretization/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks, package approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/R-discretization FEDORA-2023-6508fabab6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6508fabab6 FEDORA-2023-b8b5382510 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8b5382510 FEDORA-2023-6508fabab6 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-6508fabab6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-6508fabab6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-b8b5382510 has been pushed to the Fedora 38 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b8b5382510 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-b8b5382510 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-6508fabab6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |