Bug 2185040

Summary:	Review Request: rust-logging_timer - Simple timers that log the elapsed time when dropped
Product:	[Fedora] Fedora	Reporter:	Mads Kiilerich <mads>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, mads, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-07 22:53:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mads Kiilerich 2023-04-06 15:11:51 UTC

Spec URL: https://gist.githubusercontent.com/kiilerix/f21eaffd3d1220e6077fa36c9125f24a/raw/3d8f77504062313c83a23fd8509c8d3904ae5b99/rust-logging_timer.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2810/99592810/rust-logging_timer-1.1.0-1.fc39.src.rpm
Description: Simple timers that log the elapsed time when dropped
Fedora Account System Username: kiilerix

This depends on the recent packaged rust-logging_timer_proc_macros , and will be needed for upgrading Mercurial to 6.4

Comment 1 Fabio Valentini 2023-04-07 13:12:05 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
? test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Note that there are quite a lot of warnings emitted during the build.
It appears that the doctests use an invalid "norun" attribute instead of "no_run". You might want to report this upstream.

Comment 2 Fedora Admin user for bugzilla script actions 2023-04-07 22:24:37 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-logging_timer

Comment 3 Fedora Update System 2023-04-07 22:52:04 UTC

FEDORA-2023-31c0e78c1d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-31c0e78c1d

Comment 4 Fedora Update System 2023-04-07 22:53:48 UTC

FEDORA-2023-31c0e78c1d has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.