Bug 2185044

Summary:	Review Request: golang-github-vultr-govultr-3 - Vultr Go API client
Product:	[Fedora] Fedora	Reporter:	Major Hayden 🤠 <mhayden>
Component:	Package Review	Assignee:	Maxwell G <maxwell>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	maxwell, package-review
Target Milestone:	---	Flags:	maxwell: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-06 20:50:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2180539, 2183746

Description Major Hayden 🤠 2023-04-06 15:32:20 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr/fedora-rawhide-x86_64/05753990-golang-github-vultr-govultr-3/golang-github-vultr-govultr-3.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/vultr/fedora-rawhide-x86_64/05753990-golang-github-vultr-govultr-3/golang-github-vultr-govultr-3-3.0.2-1.fc39.src.rpm
Description: Vultr Go API client
Fedora Account System Username: mhayden

This package came about because golang-github-vultr-govultr-2 needs an upgrade to 3.0.2 (BZ 2180539) to support the latest vultr-cli release (BZ 2183746).

Comment 1 Maxwell G 2023-04-06 15:50:29 UTC

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The latest version is packaged.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 2 Major Hayden 🤠 2023-04-06 15:56:47 UTC

Thank you, Maxwell!

Comment 3 Fedora Admin user for bugzilla script actions 2023-04-06 15:58:17 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-vultr-govultr-3

Comment 4 Fedora Update System 2023-04-06 20:48:17 UTC

FEDORA-2023-6085e44fed has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-6085e44fed

Comment 5 Fedora Update System 2023-04-06 20:50:58 UTC

FEDORA-2023-6085e44fed has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.