Bug 2185239

Summary: dnf 4.15 broke repoquery's "%{INSTALLTIME}" queryformat
Product: [Fedora] Fedora Reporter: Geraldo Simião <geraldo.simiao.kutz>
Component: dnfAssignee: Jan Kolarik <jkolarik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 37CC: daniel.mach, decathorpe, jkolarik, jmracek, jrohel, mblaha, packaging-team-maint, pkratoch, rpm-software-management, rust-sig, vmukhame
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dnf-4.15.1-1.fc38 dnf-4.15.1-1.fc37 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-20 01:48:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Geraldo Simião 2023-04-07 13:50:13 UTC
Description of problem:
When trying to start fedora-update-feedback-2.1.1-1.fc37.x86_64, at the moment it asks for FAS password, after typing the correct password it returns: Error: "Failed to parse dnf output: input contains invalid characters".

Version-Release number of selected component (if applicable):

fedora-update-feedback-2.1.1-1.fc37.x86_64

p11-kit-trust-0.24.1-3.fc37.x86_64
rust-srpm-macros-24-1.fc37.noarch


This error startedafter this upgrade: 
Upgrade   python-unversioned-command-3.11.3-1.fc37.noarch         @updates-testing
    Upgraded  python-unversioned-command-3.11.2-1.fc37.noarch         @@System
    Upgrade   python3-3.11.3-1.fc37.x86_64                            @updates-testing
    Upgraded  python3-3.11.2-1.fc37.x86_64                            @@System
    Upgrade   python3-copr-1.128-1.fc37.noarch                        @updates-testing
    Upgraded  python3-copr-1.125-1.fc37.noarch                        @@System
    Upgrade   python3-dnf-4.15.0-1.fc37.noarch                        @updates-testing
    Upgraded  python3-dnf-4.14.0-1.fc37.noarch                        @@System
    Upgrade   python3-dnf-plugins-core-4.4.0-1.fc37.noarch            @updates-testing
    Upgraded  python3-dnf-plugins-core-4.3.1-1.fc37.noarch            @@System
    Obsoletos python3-dnf-plugin-system-upgrade-4.0.17-1.fc37.noarch  @@System
    Upgrade   python3-dnf-plugins-extras-common-4.1.0-1.fc37.noarch   @updates-testing
    Upgraded  python3-dnf-plugins-extras-common-4.0.17-1.fc37.noarch  @@System
    Upgrade   python3-libs-3.11.3-1.fc37.x86_64                       @updates-testing
    Upgraded  python3-libs-3.11.2-1.fc37.x86_64                       @@System
    Upgrade   python3-tkinter-3.11.3-1.fc37.x86_64                    @updates-testing
    Upgraded  python3-tkinter-3.11.2-1.fc37.x86_64                    @@System




How reproducible:
allways


Steps to Reproduce:
1.start fedora-update-feedback
2.type FAS password
3.get ERROR

Actual results:
Error message

Expected results:
Query repos and start feedback session

Aditional info:
journalctl -f didn't helped much

Tried gdb and it gave this too:
(gdb) r
Starting program: /usr/bin/fedora-update-feedback 
Downloading separate debug info for system-supplied DSO at 0x7ffff7fc6000
Downloading separate debug info for /lib64/libssl.so.3                                                                                                               
Downloading separate debug info for /home/geraldo/.cache/debuginfod_client/ec66552a3db19f64f2810273283ab3f335f6d9a0/debuginfo                                        
Downloading separate debug info for /lib64/libcrypto.so.3                                                                                                            
Downloading separate debug info for /lib64/libgcc_s.so.1                                                                                                             
Downloading separate debug info for /home/geraldo/.cache/debuginfod_client/bad96a3adc0a3a006e7ef4900ff3ae1ddcc33ed2/debuginfo                                        
Downloading separate debug info for /lib64/libm.so.6                                                                                                                 
Downloading separate debug info for /lib64/libc.so.6                                                                                                                 
[Thread debugging using libthread_db enabled]                                                                                                                        
Using host libthread_db library "/lib64/libthread_db.so.1".
Downloading separate debug info for /lib64/libz.so.1
[New Thread 0x7ffff77426c0 (LWP 4237)]                                                                                                                               
[New Thread 0x7ffff75416c0 (LWP 4238)]
[New Thread 0x7ffff73406c0 (LWP 4239)]
[New Thread 0x7ffff713f6c0 (LWP 4240)]
[New Thread 0x7ffff6f3e6c0 (LWP 4241)]
[New Thread 0x7ffff6d3d6c0 (LWP 4242)]
[New Thread 0x7ffff6b3c6c0 (LWP 4243)]
[New Thread 0x7ffff693b6c0 (LWP 4244)]
[New Thread 0x7ffff673a6c0 (LWP 4245)]
[Detaching after vfork from child process 4246]
FAS Password: [Thread 0x7ffff673a6c0 (LWP 4245) exited]

[Detaching after vfork from child process 8380]
[Detaching after vfork from child process 8381]
[Detaching after vfork from child process 8382]
[Detaching after vfork from child process 8387]
[Detaching after vfork from child process 8388]
[Thread 0x7ffff6b3c6c0 (LWP 4243) exited]
Error: [Thread 0x7ffff693b6c0 (LWP 4244) exited]
"Failed to parse dnf output: input contains invalid characters"
[Thread 0x7ffff6d3d6c0 (LWP 4242) exited]
[Thread 0x7ffff6f3e6c0 (LWP 4241) exited]
[Thread 0x7ffff713f6c0 (LWP 4240) exited]
[Thread 0x7ffff73406c0 (LWP 4239) exited]
[Thread 0x7ffff75416c0 (LWP 4238) exited]
[Thread 0x7ffff77426c0 (LWP 4237) exited]
[Inferior 1 (process 3930) exited with code 01]
(gdb) exit

Comment 1 Geraldo Simião 2023-04-07 13:51:12 UTC
Operating System: Fedora Linux 37
KDE Plasma Version: 5.27.4
KDE Frameworks Version: 5.105.0
Qt Version: 5.15.8
Kernel Version: 6.2.9-200.fc37.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-3632QM CPU @ 2.20GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 4000
Manufacturer: Acer
Product Name: Aspire V3-571

Comment 2 Fabio Valentini 2023-04-07 14:43:37 UTC
Parsing DNF output has nothing to do with the login. If the login failed, you would get a different error message. I an reproduce this issue on my local system, where I still have a valid session cookie.

This error occurs later, where fedora-update-feedback queries dnf (as mentioned by the error message: "Failed to parse dnf output: input contains invalid characters".).

It seems to be a regression in dnf 4.15, which broke the `%{INSTALLTIME}` option in "dnf repoquery":
https://bodhi.fedoraproject.org/updates/FEDORA-2023-308ef1c754#comment-2979552

Comment 3 Geraldo Simião 2023-04-07 16:04:35 UTC
Oh, ok. Good that you get where the problem is.
If there's a scratch build that someone wanna I test here, just let me know.

Comment 4 Fabio Valentini 2023-04-10 19:25:35 UTC
It appears that the validation that was introduced with version 4.15 (to fix https://bugzilla.redhat.com/show_bug.cgi?id=2140884 ) excludes some valid identifiers that previously worked. Looking into it further, it appears that while %{INSTALLTIME} no longer works, %{installtime} *does*, so I will use this as a workaround.

Comment 5 Jan Kolarik 2023-04-17 04:58:08 UTC
A fix from @jlebon was already merged in the upstream to fix this problem: https://github.com/rpm-software-management/dnf/pull/1922.

Comment 6 Fedora Update System 2023-05-18 09:53:34 UTC
FEDORA-2023-f418df9544 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f418df9544

Comment 7 Fedora Update System 2023-05-18 09:53:34 UTC
FEDORA-2023-7b8cb5535a has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b8cb5535a

Comment 8 Fedora Update System 2023-05-19 02:04:50 UTC
FEDORA-2023-7b8cb5535a has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7b8cb5535a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b8cb5535a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-05-19 02:20:05 UTC
FEDORA-2023-f418df9544 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-f418df9544`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f418df9544

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-05-20 01:48:03 UTC
FEDORA-2023-f418df9544 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-05-24 01:13:35 UTC
FEDORA-2023-7b8cb5535a has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.