Bug 2185394

Summary:	Review Request: rust-indextree - Arena based tree structure
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-29 02:53:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description blinxen 2023-04-08 21:48:41 UTC

Spec URL: https://blinxen.fedorapeople.org/rust-indextree/rust-indextree.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-indextree/rust-indextree-4.6.0-1.fc39.src.rpm
Description: Arena based tree structure by using indices instead of reference counted pointers.
Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-04-20 20:41:02 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

You might want to exclude the "Makefile" from getting installed, but that's not a blocking issue.

Comment 2 Fedora Admin user for bugzilla script actions 2023-04-20 20:51:17 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-indextree

Comment 3 blinxen 2023-04-20 21:21:00 UTC

Thanks for the review!

> You might want to exclude the "Makefile" from getting installed, but that's not a blocking issue

Thanks for the reminder --> https://src.fedoraproject.org/rpms/rust-indextree/blob/rawhide/f/rust-indextree.spec#_37

Comment 4 Fedora Update System 2023-04-20 21:39:32 UTC

FEDORA-2023-e1e2f6f41a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e1e2f6f41a

Comment 5 Fedora Update System 2023-04-21 03:21:13 UTC

FEDORA-2023-e1e2f6f41a has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e1e2f6f41a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e1e2f6f41a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-04-29 02:53:01 UTC

FEDORA-2023-e1e2f6f41a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.