Bug 218581

http://www.mediawiki.org/wiki/Extension:OpenID

I (or whoever beats me to it) need to package openid and yadis php libs by
OpenIDEnabled.com first.

I'm converting this into a new package request. Please note that this is a
top-level approach, e.g. there are two packages which I will submit later today
needed by this package as well as some changes to the mediawiki package itself.

Spec URL: http://dl.atrpms.net/all/mediawiki-openid.spec
SRPM URL: http://dl.atrpms.net/all/mediawiki-openid-0.6.1-3.at.src.rpm
Description: 
This extension lets users log in with an OpenID instead of a username
and password. An OpenID is a special URL that people can use to log in
to a Web site. The extension also lets users who have an account on
the wiki log in to other OpenID-aware Web sites with their wiki user
page as their OpenID.

You must create a table in your MediaWiki database to hold the OpenID
URL mappings. The openid_table.sql script in
%{_datadir}/mediawiki/extensions/OpenID/ should do the
trick. Typically you do this using the mysql command-line client, like
so:

        mysql -h yourdbhost -u youradminuser -p yourwikidb < openid_table.sql

In your MediaWiki LocalSettings.php, add the following line some place
towards the bottom of the file:

        require_once("$IP/extensions/OpenID/OpenID.php");

Theoretically it should work out of the box, but you'll almost
definitely want to set the trust root and access controls.

(In reply to comment #2)
> Description: 
> This extension lets users log in with an OpenID instead of a username
> and password. An OpenID is a special URL that people can use to log in
> to a Web site. The extension also lets users who have an account on
> the wiki log in to other OpenID-aware Web sites with their wiki user
> page as their OpenID.
> 
> You must create a table in your MediaWiki database to hold the OpenID
> URL mappings. The openid_table.sql script in
> %{_datadir}/mediawiki/extensions/OpenID/ should do the
> trick. Typically you do this using the mysql command-line client, like
> so:
> 
>         mysql -h yourdbhost -u youradminuser -p yourwikidb < openid_table.sql
> 
> In your MediaWiki LocalSettings.php, add the following line some place
> towards the bottom of the file:
> 
>         require_once("$IP/extensions/OpenID/OpenID.php");
> 
> Theoretically it should work out of the box, but you'll almost
> definitely want to set the trust root and access controls.
> 
> 

Cut it off after the first paragraph, if you think you have to provide an extra
file such as README.Fedora (not sure what the standard is) explaining the
proceedure.

This is a confusing ticket.  Who is the submitter?  Axel, if it's you, you
should open your own ticket so that this doesn't look like Jeff's package.

I could start cloning the ticket and mark duplicates to reset the reporter
field, but I think it's bureaucratic overkill. You lose the comment segmentation
and perhaps even the Cc fields. (it's been a while since I last cloned a bug in
this bugzilla, so I'm not sure about the Cc fields).

Even if it is not immediately evident who the submitter is a reviewer should not
care whether this is Jeff or me whom he ponders the package's faults on, and the
work flow of this particular ticket is rather natural: Someone asks for a new
package and it gets processed at the same place.

The worst that can happen is some bugzilla querying script counting one
submission more to Jeff than to me, I think we'll manage. :)

Anyway this package set (e.g. the submitted dependencies as well) seems to not
really stir interest even though it was specifically asked for - it's rottening
since more than half a year now. :/

Well, there's one more reviewer you won't be getting.

Just because the reviewer may think on first sight this was submitted by Jeff?
Is Jeff known to be a reviewer eater? :)

Any news?

(In reply to comment #8)
> Any news?

Want to pick up the review?

(In reply to comment #9)

> Want to pick up the review?

Already picked up :)
Wait a little...

btw  0.7.0 is out - why not to upgrade?

I updated package to 0.7.0, fixed wrong License (GPLv2+), and slightly changed
BuildRoot - here is the patch:

http://peter.fedorapeople.org/mediawiki-openid.spec.diff

Please apply it and I'll make a formal review ASAP.

Any progress here?

I just found that Axel updated his spec-file so I'll review it ASAP.

Sorry Peter, I completely forgot to update this bugzilla. :/

REVIEW:

[-] rpmlint is not silent - just add empty %build section into spec-file
[+] The package named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format %{name}.spec 
[+] The package meets the Packaging Guidelines.
[+] The package licensed with a Fedora approved license and meet the Licensing
Guidelines.
[+] The License field in the package spec file matches the actual license.
[+] The spec file written in American English.
[+] The spec file for the package is legible. 
[+] The sources used to build the package matches the upstream source
[+] The package successfully builds.
[+] All build dependencies listed in BuildRequires.
[+] The package owns all directories that it creates.
[+] The package does not contain any duplicate files in the %files listing.
[+] Permissions on files are set properly.
[+] The package have a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[+] The package consistently use macros.
[+] The package contains code, or permissable content.
[+] Packages does not own files or directories already owned by other packages.
[+] All filenames in rpm packages are valid UTF-8.

SHOULD Items:

[-] You SHOULD query upstream to include License among sources. It's not a
blocker though.

Some notes: 

* The description of package rather big. Maybe it would be better to put it into
separate file? Saying, README.fedora or similar. Just my IMHO, actually and not
a blocker.

* From description I realized that openid_table.sql needs only for creating a
database in MySQL, so I think that we should separate this file from
php-scripts. Maybe we should move it into %doc section?

Just settle my two doubts, satisfy rpmlint with empty %build section and I'll
approve it.

Just FYI here is a srpm (created from your latest spec) which I reviewed:

ftp://lux.di-net.ru/pub/apps/SRPMS/mediawiki-openid-0.7.0-4.src.rpm

Any news?

Spec URL: http://dl.atrpms.net/all/mediawiki-openid.spec
SRPM URL: http://dl.atrpms.net/all/mediawiki-openid-0.7.0-5.src.rpm

* Tue Mar  4 2008 Axel Thimm <Axel.Thimm> - 0.7.0-5
- Move *.sql to %%doc.
- move part of %%description to a README.1st file.
- add empty %%build.

All items but getting feedback from upstream on including the license should be
resolved now.

OK, thanks.

APPROVED.

Axel: 

Please use the cvs template so we know what branches you want, etc. 
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Reset the fedora-cvs flag when you are ready. 

New Package CVS Request
=======================
Package Name: mediawiki-openid
Short Description: The OpenID extension for MediaWiki
Owners: athimm
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: no (too many people in this group)

cvs done.

Thanks for review & cvs op!

*** Bug 439340 has been marked as a duplicate of this bug. ***

mediawiki-openid-0.8.2-7 has been submitted as an update for Fedora 7

This package shouldn't have passed review as it has Requires: that aren't
actually in Fedora, e.g. php-pear-Auth-OpenID which is still in review (bug #227190)

Broken deps for i386
----------------------------------------------------------
	mediawiki-openid-0.7.0-5.noarch requires php-pear-Auth-OpenID
	mediawiki-openid-0.7.0-5.noarch requires php-pear-Services-Yadis

see:

http://koji.fedoraproject.org/mash/rawhide-20080413/logs/depcheck

This should probably be blocked from F-9 until such time as the dependencies are
fully packaged and available. 

mediawiki-openid-0.8.2-7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mediawiki-openid'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F7/FEDORA-2008-2857

What is the correct state for this bug?

per comment #26 seems to be saying this bug is not fixed and all the other
comments are about updates to F7 which is currently EOL... and yet this bug is
open against 'rawhide' :-)

This request is blocked by two (see dependencies) another review requests (which
I'm reviewing). They currently in suspended state in a middle of review - I'll
ping Axel.

There is another one attempt by Ian Weller to push php-openid modules into Fedora:

https://bugzilla.redhat.com/show_bug.cgi?id=439285

I'll contact Ian asap for coordination.

One of the dependencies is no dependency anymore in recent versions, so I'm
dropping the block. It's now actually only one package to be reviewed and it's
through, and the review comments look encouraging (nothing major).

As to F7 builds: There will only be an oldest-Fedora-build as this package is
trans-distro identical. koji has some magic to inherit this to all later
releases automatically. Which means that once the dependencies are in, one will
either stil find the F7 build and use that, or have an F8 build for F8/F9/devel.

Still no branch for F-9.

See

https://fedorahosted.org/rel-eng/ticket/768

for details.

OK, finally branched for F-9.