Bug 2185934

Summary:	NFS repository messages less useful and in a less natural place than before
Product:	[Fedora] Fedora	Reporter:	Adam Williamson <awilliam>
Component:	anaconda	Assignee:	Anaconda Maintenance Team <anaconda-maint-list>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	39	CC:	anaconda-maint-list, vponcova, vslavik, w
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	openqa
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-08 16:25:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Adam Williamson 2023-04-11 16:28:36 UTC

Since recent Rawhide changes - probably 31cd5e7eab51ae05ec1b58f120f90e034eff679c - the log messages relating to NFS repositories are less useful and in a less useful place than before.

Previously, the messages appeared in packaging.log (where you'd expect to find them), and one of them looked like this:

10:38:37,252 DBG packaging: Add the 'addrepo' repository (RepoConfigurationData(cost=1000, enabled=True, excluded_packages=[], included_packages=[], installation_enabled=False, name='addrepo', origin='USER', proxy='', ssl_configuration=SSLConfigurationData(), ssl_verification_enabled=True, type='BASEURL', url='nfs://172.16.2.110:/mnt/update_repo')).

note the 'url' given is the actual url of the repository.

Now, the messages appear in syslog (probably not where you'd expect to find them), and that same message looks like this:

14:34:24,666 WARNING org.fedoraproject.Anaconda.Modules.Payloads:DEBUG:anaconda.modules.payloads.payload.dnf.repositories:Add the 'addrepo' repository (RepoConfigurationData(cost=1000, enabled=True, excluded_packages=[], included_packages=[], installation_enabled=False, name='addrepo', origin='USER', proxy='', ssl_configuration=SSLConfigurationData(), ssl_verification_enabled=True, type='BASEURL', url='file:///run/install/sources/mount-0000-nfs-device')).

it's got a useless prefix on it which is annoying, but more importantly the url is now not the actual url of the NFS repo at all, but some kind of internal anaconda redirection file URL, which is of no use to the user.

Comment 1 Adam Williamson 2023-04-11 16:29:29 UTC

I noticed this because it messes up openQA's checks for verifying that the repo we attempted to add actually got added, but even if I hack up that check to keep working, this is clearly a less useful log message than before.

Comment 2 Fedora Release Engineering 2023-08-16 08:15:06 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.

Comment 3 Aoife Moloney 2024-11-08 10:51:23 UTC

This message is a reminder that Fedora Linux 39 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 39 on 2024-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '39'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 39 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 4 Adam Williamson 2024-11-08 16:25:53 UTC

Hmm, well, there do seem to be more messages relating to the NFS source in packaging.log now:

DEBUG:anaconda.modules.payloads.source.source_base:The configuration is set to: RepoConfigurationData(cost=1000, enabled=True, excluded_packages=[], included_packages=[], installation_enabled=False, name='', origin='USER', proxy='', ssl_configuration=SSLConfigurationData(), ssl_verification_enabled=True, type='BASEURL', url='nfs:nfsvers=4:172.16.2.110:/repo')
DEBUG:anaconda.modules.payloads.payload.payload_base:New sources [Source(type='NFS', url='nfs:nfsvers=4:172.16.2.110:/repo')] were added.
INFO:anaconda.core.threads:Running Thread: AnaTaskThread-TearDownDNFSourcesTask-1 (139859328595648)
DEBUG:anaconda.modules.payloads.base.initialization:Tearing down a source: Source(type='NFS', url='nfs:nfsvers=4:172.16.2.110:/repo')
DEBUG:anaconda.modules.payloads.base.initialization:Running a task: Unmount an installation source
DEBUG:anaconda.modules.payloads.source.mount_tasks:Unmounting installation source
INFO:program:Running... umount /run/install/sources/mount-0001-nfs-iso
INFO:program:stderr:
INFO:program:b'umount: /run/install/sources/mount-0001-nfs-iso: no mount point specified.'
DEBUG:program:Return code: 32
DEBUG:anaconda.modules.payloads.base.initialization:Running a task: Unmount an installation source
DEBUG:anaconda.modules.payloads.source.mount_tasks:Unmounting installation source
INFO:program:Running... umount /run/install/sources/mount-0000-nfs-device
INFO:program:stderr:
INFO:program:b'umount: /run/install/sources/mount-0000-nfs-device: no mount point specified.'
DEBUG:program:Return code: 32
DEBUG:anaconda.modules.payloads.base.initialization:Setting up a source: Source(type='NFS', url='nfs:nfsvers=4:172.16.2.110:/repo')
DEBUG:anaconda.modules.payloads.base.initialization:Running a task: Set up an NFS source
INFO:anaconda.modules.common.task.task:Set up an NFS source
DEBUG:anaconda.modules.payloads.source.nfs.initialization:Setting up an NFS source: nfs:nfsvers=4:172.16.2.110:/repo
INFO:program:Running... mount -t nfs -o nfsvers=4,nolock 172.16.2.110:/repo /run/install/sources/mount-0000-nfs-device
DEBUG:anaconda.modules.payloads.source.source_base:The repository is set to: RepoConfigurationData(cost=1000, enabled=True, excluded_packages=[], included_packages=[], installation_enabled=False, name='', origin='USER', proxy='', ssl_configuration=SSLConfigurationData(), ssl_verification_enabled=True, type='BASEURL', url='file:///run/install/sources/mount-0000-nfs-device')

so on the whole that seems a bit better.