Bug 2186230

Summary: [MDR] Cannot unassign the DRpolicy applied to an appset based app
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: Parikshith <pbyregow>
Component: odf-drAssignee: Benamar Mekhissi <bmekhiss>
odf-dr sub component: ramen QA Contact: avdhoot <asagare>
Status: CLOSED DEFERRED Docs Contact:
Severity: high    
Priority: unspecified CC: bmekhiss, ebenahar, hnallurv, muagarwa, ocs-bugs, odf-bz-bot, sheggodu, skatiyar, srangana
Version: 4.13Flags: asagare: needinfo? (bmekhiss)
Target Milestone: ---   
Target Release: ODF 4.13.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.13.0-178 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-08 10:54:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Parikshith 2023-04-12 13:39:28 UTC
Created attachment 1957174 [details]
screenshot 1

Description of problem (please be detailed as possible and provide log
snippests):
After protecting the appset app by drpolicy, not able to remove it.

Version of all relevant components (if applicable):
ocp: 4.13.0-0.nightly-2023-04-01-062001
odf: 4.13.0-124 
acm: 2.7.2(GA)

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
no

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
3/3

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1. Configure 3 OCP 4.13 clusters. hub/acm, c1 and c2. 
2. Configure MDR
3. Deploy Appset based apps on c1. Apply dr policy to the apps.
4. After policy is applied successfully, unprotect the app via Manage policy for ApplicationSets menu. (screenshot 1)


Actual results:
Manage policy for ApplicationSets menu still shows the app is protected (screenshot 2) and drpc exists.

$oc get drpc new-app-8-placement-drpc -n openshift-gitops
NAME                       AGE   PREFERREDCLUSTER   FAILOVERCLUSTER   DESIREDSTATE   CURRENTSTATE
new-app-8-placement-drpc   34m   pbyregow-c1                                         Deployed

Expected results:
The drpolicy assigned to app should be removed.

Additional info:

Comment 4 Sanjal Katiyar 2023-04-12 14:40:02 UTC
just to point out few related things:

1. Disabling DR is not supported for 4.13, we will hide/disable this option from UI: https://bugzilla.redhat.com/show_bug.cgi?id=2181112

2. Multiple AppSet using same Placement is not recommend, and will be documented in the doc as well.

3. When AppSet is DR protected, we need to add "cluster.open-cluster-management.io/experimental-scheduling-disable" annotation to the Placement CR... if we will enable DR from the UI, UI will take care of adding this annotation for us (but if we are using CLI, it is easy to miss this step).

4. When we disable DR for an AppSet, UI removes this label from the Placement CR as well.

I checked the cluster (thanks Parikshith for sharing the cluster), issue is DRPC CR is stuck on "drpc.ramendr.openshift.io/finalizer" finalizer, which is preventing it from getting deleted.

workaround for now: clean it up manually.

Comment 13 avdhoot 2023-06-06 07:46:30 UTC

since unassigning is disabled from UI (screenshot 3)
So, Do I need to check anything else to verify this bz?
If yes ,can you please share more details on it?

Comment 19 Sanjal Katiyar 2023-06-06 14:44:05 UTC
Note (just for ref): This BZ is for admin flow (where admin can bulk assign/un-assign policies).

Initially it was planned to support un-assigning from the UI in 4.14 but that epic: https://issues.redhat.com/browse/RHSTOR-4137 moved out to 4.15 now. So, my suggestion will be either to close the BZ or test it from CLI.

(else keep this BZ open till 4.15, but I personally don't see any reason for this because it will be tested as part of the epic #4137 anyway).

Comment 20 avdhoot 2023-06-08 10:54:13 UTC
As support of un-assigning from the UI  epic: https://issues.redhat.com/browse/RHSTOR-4137 moved out to 4.15 now and Based on developer's suggestion closing this BZ.