Bug 2187633

Summary: Remove backspace event handling from @ behavior
Product: [Community] Bugzilla Reporter: VĂ­t Ondruch <vondruch>
Component: Creating/Changing BugsAssignee: Jeff Fearn 🐞 <jfearn>
Status: CLOSED CURRENTRELEASE QA Contact: Jeff Fearn 🐞 <jfearn>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.0CC: agk
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.0.4-rh88 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2219332 (view as bug list) Environment:
Last Closed: 2023-07-03 00:17:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description VĂ­t Ondruch 2023-04-18 09:01:20 UTC 
Description of problem:
I am not convinced the @ behavior adds any benefit. Quite contrary, I would dare to say it is annoying. I am using @Name to address somebody, but the @ behavior makes this completely unusable, because right I start to write the name, it jumps to other field. I get back to continue and I am send back to the need info field again. If I want to correct typo I did due to jumps, maybe just remove the colon behind the name, again I eng up in the need info field. I have certainly submitted my changes prematurely due to this behavior.

Base on this, I'd like to ask to disable this feature.


Version-Release number of selected component (if applicable):
Bugzilla 5.0.4.rh85

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
Typing @ right at the beginning of comment send me to "Need info" field. Get back, continue typing, correcting typo by pressing backspace, I end up again in "Need info"


Expected results:
The behavior of @ is so annoying that I'd propose to completely disable it. The other probably acceptable option is to jump to "Need info" field just for the first time, when @ is the only character in the comment field (but I don't know the precise specification of the @ behavior, so maybe there might be other option).


Additional info:
Comment 1 Jeff Fearn 🐞 2023-04-27 03:30:59 UTC 
I think this can be changed so it only triggers when you type the '@', if you are doing anything else it should not trigger.

@
Comment 2 Jeff Fearn 🐞 2023-04-27 03:34:07 UTC 
Bug 2186648 reverted the behavior of the enter key so it probably needs additional changes.
Comment 3 Jeff Fearn 🐞 2023-06-28 01:49:04 UTC 
On QA server.

1. In a comment type '@'

Focus moves to needinfo box.

2. press escape

Focus returns to comment box

3. type 'abcd'

Focus remains in the comment box

4. type '@'

Focus remains in the comment box

5. press backspace

Focus remains in the comment box

6. press backspace all the way to the start

Focus remains in the comment box

7.type '@'

Focus moves to needinfo box

8. press escape

Focus returns to comment box

9. type 'abcd'

Focus remains in the comment box

10. type ' @'

Focus moves to needinfo box.

11. type a user name and select it

User name is added to comment text box
Comment 4 Jeff Fearn 🐞 2023-06-28 23:01:36 UTC 
This fix has been deployed to stage Bugzilla for a short public testing phase.

https://bugzilla.stage.redhat.com
Comment 5 VĂ­t Ondruch 2023-06-29 08:02:32 UTC 
I am testing in the staging instance and while the behavior is probably improved, I still struggle submitting the changes unexpectedly (and the results might be visible in bug #1995819). The reproducer should be:

1) Start typing a comment by `@` character
2) The focus is moved into the search box
3) Start to type `pval` (I hope that my colleague Pavel Valena would be forgiving, should this result in some needinfos for him ;))
4) Press `Enter`

IMHO, the `Enter` in the search box cannot submit the changes of the ticket no matter what.
Comment 6 Jeff Fearn 🐞 2023-07-02 23:25:25 UTC 
(In reply to VĂ­t Ondruch from comment #5)
> I am testing in the staging instance and while the behavior is probably
> improved, I still struggle submitting the changes unexpectedly (and the
> results might be visible in bug #1995819). The reproducer should be:
> 
> 1) Start typing a comment by `@` character
> 2) The focus is moved into the search box
> 3) Start to type `pval` (I hope that my colleague Pavel Valena would be
> forgiving, should this result in some needinfos for him ;))
> 4) Press `Enter`
> 
> IMHO, the `Enter` in the search box cannot submit the changes of the ticket
> no matter what.

Hi, this bug isn't about how the user select widget works, you will need another bug for that.

It looks like if you use that widget, anywhere, such as CC, and you hit enter without selecting an entry in the drop down then it submits the form. This is actually correct from accessibility standards perspective, but it sucks. We would need to change how the text box works for this use case, but do so in a way that doesn't break accessibility.

i.e. we will need to work out how to make it non-standard and communicate that to browsers in accessibility mode, readers, etc.

In the meantime if you decide you don't want to select a user, then use the escape key to exit the widget.
Comment 7 Jeff Fearn 🐞 2023-07-03 00:17:37 UTC 
This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug.