Bug 2187668

Summary:	Review Request: rust-cargo-config2 - Load and resolve Cargo configuration
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Maxwell G <maxwell>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	maxwell, package-review
Target Milestone:	---	Flags:	maxwell: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-cargo-config2-0.1.6-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-19 17:08:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2187698

Description Fabio Valentini 2023-04-18 12:02:46 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-cargo-config2.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cargo-config2-0.1.6-1.fc38.src.rpm

Description:
Load and resolve Cargo configuration.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-04-18 12:03:54 UTC

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=100098479

Note: I am packaging v0.1.6 intentionally, even though v0.1.7 is the latest version. However, v0.1.7 depends on v0.15 of the cfg-expr crate, which is still at v0.14 in Fedora, and can't easily be updated to v0.15 right now.

Comment 2 Maxwell G 2023-04-18 22:19:33 UTC

This package was generated using rust2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is sane.
- [-] (justified) The latest version is packaged
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The license text is included in the package and is marked with %license.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] The package complies with the Rust and general Packaging Guidelines.

Package approved. Thanks!

Comment 3 Fabio Valentini 2023-04-19 16:17:04 UTC

Thanks for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-19 16:17:37 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-config2

Comment 5 Fabio Valentini 2023-04-19 17:08:42 UTC

Imported and built for rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-84a742d94e