Bug 2187670
| Summary: | Review Request: rust-cargo-options - Reusable common Cargo command line options | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Maxwell G <maxwell> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | maxwell, package-review |
| Target Milestone: | --- | Flags: | maxwell:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rust-cargo-options-0.6.0-1.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-04-19 17:00:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2187698 | ||
|
Description
Fabio Valentini
2023-04-18 12:18:04 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=100098622 This package was generated using rust2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag uses the correct identifiers, and it reflects the package contents and Cargo metadata. - [x] The license text is included in the package and is marked with %license. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. (There are some warnings about zero length test files.) - [-] (Justified with a comment in the specfile) The package runs tests in %check. - [x] The package complies with the Rust and general Packaging Guidelines. Package approved. Thanks! > (There are some warnings about zero length test files.)
Hmm, should the tests be excluded from the package all together? In other packaging ecosystems I'm involved with (e.g. Python and Ansible collections), it's standard to remove the tests from the built package even if upstream installs them, but I'm not sure if Rust is different in this regard.
Thanks for the review! > Hmm, should the tests be excluded from the package all together? Usually the test sources don't hurt, and we don't remove them unless they include problematic things like architecture-specific binaries or other large test fixtures like images. > but I'm not sure if Rust is different in this regard. Not really, but we don't have Guidelines for it, so it's more done on a case-by-case basis. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-options Imported and built for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-38a733702d |