Bug 2187680

Summary:	Review Request: rust-fat-macho - Mach-O Fat Binary Reader and Writer
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-17 19:18:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2187679
Bug Blocks:	2187698

Description Fabio Valentini 2023-04-18 12:36:53 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-fat-macho.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-fat-macho-0.4.6-1.fc38.src.rpm

Description:
Mach-O Fat Binary Reader and Writer.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-04-18 12:46:58 UTC

Successful COPR build with dependencies:
https://copr.fedorainfracloud.org/coprs/decathorpe/maturin/build/5787159/

Comment 2 Michel Lind 2023-05-17 18:39:18 UTC

Taking this review

Comment 3 Michel Lind 2023-05-17 18:53:59 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fabio Valentini 2023-05-17 19:03:38 UTC

Thanks for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-05-17 19:04:03 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fat-macho

Comment 6 Fabio Valentini 2023-05-17 19:18:51 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-ca5a6ef2de