Bug 2187741

Summary:	cvs: Port to modern C
Product:	[Fedora] Fedora	Reporter:	Arjun Shankar <ashankar>
Component:	cvs	Assignee:	Arjun Shankar <ashankar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fweimer, kasal, ppisar
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	cvs-1.11.23-65.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-04-19 14:00:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2141798

Description Arjun Shankar 2023-04-18 15:06:36 UTC

User-Agent:       Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36
Build Identifier: 

https://fedoraproject.org/wiki/Changes/PortingToModernC
https://fedoraproject.org/wiki/Toolchain/PortingToModernC

Since cvs hasn't had a release since 2008 (https://savannah.nongnu.org/news/?group=cvs), I'm filing this bug to track changes in Fedora's cvs package to allow it to build as C99.

Reproducible: Always

Comment 1 Petr Pisar 2023-04-19 06:59:42 UTC

Excuse me, what's the point of adding lib/sighandle.h with SIG_register() declaration, if the same declaration is already made in src/cvs.h:

$ grep -Hnr SIG_register
lib/sighandle.h:1:extern int SIG_register (int sig, RETSIGTYPE (*fn)());
lib/sighandle.c:173:int SIG_register(sig,fn)
[...]
src/cvs.h:488:int SIG_register PROTO((int sig, SIGCLEANUPPROC sigcleanup));

Comment 2 Arjun Shankar 2023-04-19 10:21:50 UTC

Thanks for pointing this out. This is an error on my part. It appears that the creation of the new file itself is an error. I should have included the SIG_deregister declaration in cvs.h. I'll file a PR with the necessary changes.

Comment 3 Arjun Shankar 2023-04-19 11:57:28 UTC

This should be better: https://src.fedoraproject.org/rpms/cvs/pull-request/3

Comment 4 Petr Pisar 2023-04-19 13:48:36 UTC

Thanks. I'm running a build.