Bug 2187797

Summary:	Review Request: rust-tracing-subscriber - Utilities for implementing and composing tracing subscribers
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	blinxen <h-k-81>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	h-k-81, package-review
Target Milestone:	---	Flags:	h-k-81: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-29 21:43:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2023-04-18 17:08:53 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-tracing-subscriber.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-tracing-subscriber-0.3.16-1.fc38.src.rpm

Description:
Utilities for implementing and composing `tracing` subscribers.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-04-18 17:08:55 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=100105504

Comment 2 Fabio Valentini 2023-04-18 17:12:26 UTC

Note: Sub-packages that provide optional / non-default functionality depend on packages which are still pending review:
https://bugzilla.redhat.com/show_bug.cgi?id=2187791
https://bugzilla.redhat.com/show_bug.cgi?id=2187798

Comment 3 blinxen 2023-05-29 19:11:10 UTC

Taking this review

General comments:

- Package was generated with rust2rpm and a feature was removed
- Feature appears to be unstable, so I guess this is OK
- Tests were deactivated because they rely on an unpublished crate. I guess this is OK but what is normally done here? Should this be reported to upstream?
- Version 0.3.17 was published

APPROVED


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "MIT License", "*No copyright* MIT
     License". 76 files have unknown license. Detailed output of
     licensecheck in /var/lib/copr-rpmbuild/results/rust-tracing-
     subscriber/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     tracing-subscriber-devel , rust-tracing-subscriber+default-devel ,
     rust-tracing-subscriber+alloc-devel , rust-tracing-subscriber+ansi-
     devel , rust-tracing-subscriber+env-filter-devel , rust-tracing-
     subscriber+fmt-devel , rust-tracing-subscriber+json-devel , rust-
     tracing-subscriber+local-time-devel , rust-tracing-
     subscriber+matchers-devel , rust-tracing-subscriber+nu-ansi-term-devel
     , rust-tracing-subscriber+once_cell-devel , rust-tracing-
     subscriber+parking_lot-devel , rust-tracing-subscriber+regex-devel ,
     rust-tracing-subscriber+registry-devel , rust-tracing-
     subscriber+serde-devel , rust-tracing-subscriber+serde_json-devel ,
     rust-tracing-subscriber+sharded-slab-devel , rust-tracing-
     subscriber+smallvec-devel , rust-tracing-subscriber+std-devel , rust-
     tracing-subscriber+thread_local-devel , rust-tracing-subscriber+time-
     devel , rust-tracing-subscriber+tracing-devel , rust-tracing-
     subscriber+tracing-log-devel , rust-tracing-subscriber+tracing-serde-
     devel
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Checking: rust-tracing-subscriber-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+default-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+alloc-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+ansi-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+env-filter-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+fmt-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+json-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+local-time-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+matchers-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+nu-ansi-term-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+once_cell-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+parking_lot-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+regex-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+registry-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+serde-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+serde_json-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+sharded-slab-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+smallvec-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+std-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+thread_local-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+time-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+tracing-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+tracing-log-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber+tracing-serde-devel-0.3.16-1.fc39.noarch.rpm
          rust-tracing-subscriber-0.3.16-1.fc39.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpd_v98c92')]
checks: 31, packages: 25

rust-tracing-subscriber+alloc-devel.noarch: W: no-documentation
rust-tracing-subscriber+ansi-devel.noarch: W: no-documentation
rust-tracing-subscriber+default-devel.noarch: W: no-documentation
rust-tracing-subscriber+env-filter-devel.noarch: W: no-documentation
rust-tracing-subscriber+fmt-devel.noarch: W: no-documentation
rust-tracing-subscriber+json-devel.noarch: W: no-documentation
rust-tracing-subscriber+local-time-devel.noarch: W: no-documentation
rust-tracing-subscriber+matchers-devel.noarch: W: no-documentation
rust-tracing-subscriber+nu-ansi-term-devel.noarch: W: no-documentation
rust-tracing-subscriber+once_cell-devel.noarch: W: no-documentation
rust-tracing-subscriber+parking_lot-devel.noarch: W: no-documentation
rust-tracing-subscriber+regex-devel.noarch: W: no-documentation
rust-tracing-subscriber+registry-devel.noarch: W: no-documentation
rust-tracing-subscriber+serde-devel.noarch: W: no-documentation
rust-tracing-subscriber+serde_json-devel.noarch: W: no-documentation
rust-tracing-subscriber+sharded-slab-devel.noarch: W: no-documentation
rust-tracing-subscriber+smallvec-devel.noarch: W: no-documentation
rust-tracing-subscriber+std-devel.noarch: W: no-documentation
rust-tracing-subscriber+thread_local-devel.noarch: W: no-documentation
rust-tracing-subscriber+time-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-log-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-serde-devel.noarch: W: no-documentation
 25 packages and 0 specfiles checked; 0 errors, 23 warnings, 0 badness; has taken 0.6 s




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 24

rust-tracing-subscriber+time-devel.noarch: W: no-documentation
rust-tracing-subscriber+ansi-devel.noarch: W: no-documentation
rust-tracing-subscriber+json-devel.noarch: W: no-documentation
rust-tracing-subscriber+std-devel.noarch: W: no-documentation
rust-tracing-subscriber+parking_lot-devel.noarch: W: no-documentation
rust-tracing-subscriber+once_cell-devel.noarch: W: no-documentation
rust-tracing-subscriber+nu-ansi-term-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-devel.noarch: W: no-documentation
rust-tracing-subscriber+env-filter-devel.noarch: W: no-documentation
rust-tracing-subscriber+smallvec-devel.noarch: W: no-documentation
rust-tracing-subscriber+fmt-devel.noarch: W: no-documentation
rust-tracing-subscriber+local-time-devel.noarch: W: no-documentation
rust-tracing-subscriber+serde-devel.noarch: W: no-documentation
rust-tracing-subscriber+matchers-devel.noarch: W: no-documentation
rust-tracing-subscriber+sharded-slab-devel.noarch: W: no-documentation
rust-tracing-subscriber+regex-devel.noarch: W: no-documentation
rust-tracing-subscriber+alloc-devel.noarch: W: no-documentation
rust-tracing-subscriber+default-devel.noarch: W: no-documentation
rust-tracing-subscriber+thread_local-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-serde-devel.noarch: W: no-documentation
rust-tracing-subscriber+tracing-log-devel.noarch: W: no-documentation
rust-tracing-subscriber+serde_json-devel.noarch: W: no-documentation
rust-tracing-subscriber+registry-devel.noarch: W: no-documentation
 24 packages and 0 specfiles checked; 0 errors, 23 warnings, 0 badness; has taken 0.1 s



Source checksums
----------------
https://crates.io/api/v1/crates/tracing-subscriber/0.3.16/download#/tracing-subscriber-0.3.16.crate :
  CHECKSUM(SHA256) this package     : a6176eae26dd70d0c919749377897b54a9276bd7061339665dd68777926b5a70
  CHECKSUM(SHA256) upstream package : a6176eae26dd70d0c919749377897b54a9276bd7061339665dd68777926b5a70


Requires
--------
rust-tracing-subscriber-devel (rpmlib, GLIBC filtered):
    (crate(tracing-core) >= 0.1.30 with crate(tracing-core) < 0.2.0~)
    cargo

rust-tracing-subscriber+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/ansi)
    crate(tracing-subscriber/fmt)
    crate(tracing-subscriber/smallvec)
    crate(tracing-subscriber/std)
    crate(tracing-subscriber/tracing-log)

rust-tracing-subscriber+alloc-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+ansi-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/fmt)
    crate(tracing-subscriber/nu-ansi-term)

rust-tracing-subscriber+env-filter-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/matchers)
    crate(tracing-subscriber/once_cell)
    crate(tracing-subscriber/regex)
    crate(tracing-subscriber/std)
    crate(tracing-subscriber/thread_local)
    crate(tracing-subscriber/tracing)

rust-tracing-subscriber+fmt-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/registry)
    crate(tracing-subscriber/std)

rust-tracing-subscriber+json-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/serde)
    crate(tracing-subscriber/serde_json)
    crate(tracing-subscriber/tracing-serde)

rust-tracing-subscriber+local-time-devel (rpmlib, GLIBC filtered):
    (crate(time/local-offset) >= 0.3.2 with crate(time/local-offset) < 0.4.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+matchers-devel (rpmlib, GLIBC filtered):
    (crate(matchers/default) >= 0.1.0 with crate(matchers/default) < 0.2.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+nu-ansi-term-devel (rpmlib, GLIBC filtered):
    (crate(nu-ansi-term/default) >= 0.46.0 with crate(nu-ansi-term/default) < 0.47.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+once_cell-devel (rpmlib, GLIBC filtered):
    (crate(once_cell/default) >= 1.13.0 with crate(once_cell/default) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+parking_lot-devel (rpmlib, GLIBC filtered):
    (crate(parking_lot/default) >= 0.12.1 with crate(parking_lot/default) < 0.13.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+regex-devel (rpmlib, GLIBC filtered):
    (crate(regex) >= 1.0.0 with crate(regex) < 2.0.0~)
    (crate(regex/std) >= 1.0.0 with crate(regex/std) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+registry-devel (rpmlib, GLIBC filtered):
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/sharded-slab)
    crate(tracing-subscriber/std)
    crate(tracing-subscriber/thread_local)

rust-tracing-subscriber+serde-devel (rpmlib, GLIBC filtered):
    (crate(serde/default) >= 1.0.140 with crate(serde/default) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+serde_json-devel (rpmlib, GLIBC filtered):
    (crate(serde_json/default) >= 1.0.82 with crate(serde_json/default) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+sharded-slab-devel (rpmlib, GLIBC filtered):
    (crate(sharded-slab/default) >= 0.1.4 with crate(sharded-slab/default) < 0.2.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+smallvec-devel (rpmlib, GLIBC filtered):
    (crate(smallvec/default) >= 1.9.0 with crate(smallvec/default) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+std-devel (rpmlib, GLIBC filtered):
    (crate(tracing-core/std) >= 0.1.30 with crate(tracing-core/std) < 0.2.0~)
    cargo
    crate(tracing-subscriber)
    crate(tracing-subscriber/alloc)

rust-tracing-subscriber+thread_local-devel (rpmlib, GLIBC filtered):
    (crate(thread_local/default) >= 1.1.4 with crate(thread_local/default) < 2.0.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+time-devel (rpmlib, GLIBC filtered):
    (crate(time/default) >= 0.3.2 with crate(time/default) < 0.4.0~)
    (crate(time/formatting) >= 0.3.2 with crate(time/formatting) < 0.4.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+tracing-devel (rpmlib, GLIBC filtered):
    (crate(tracing) >= 0.1.35 with crate(tracing) < 0.2.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+tracing-log-devel (rpmlib, GLIBC filtered):
    (crate(tracing-log) >= 0.1.3 with crate(tracing-log) < 0.2.0~)
    (crate(tracing-log/log-tracer) >= 0.1.3 with crate(tracing-log/log-tracer) < 0.2.0~)
    (crate(tracing-log/std) >= 0.1.3 with crate(tracing-log/std) < 0.2.0~)
    cargo
    crate(tracing-subscriber)

rust-tracing-subscriber+tracing-serde-devel (rpmlib, GLIBC filtered):
    (crate(tracing-serde/default) >= 0.1.3 with crate(tracing-serde/default) < 0.2.0~)
    cargo
    crate(tracing-subscriber)



Provides
--------
rust-tracing-subscriber-devel:
    crate(tracing-subscriber)
    rust-tracing-subscriber-devel

rust-tracing-subscriber+default-devel:
    crate(tracing-subscriber/default)
    rust-tracing-subscriber+default-devel

rust-tracing-subscriber+alloc-devel:
    crate(tracing-subscriber/alloc)
    rust-tracing-subscriber+alloc-devel

rust-tracing-subscriber+ansi-devel:
    crate(tracing-subscriber/ansi)
    rust-tracing-subscriber+ansi-devel

rust-tracing-subscriber+env-filter-devel:
    crate(tracing-subscriber/env-filter)
    rust-tracing-subscriber+env-filter-devel

rust-tracing-subscriber+fmt-devel:
    crate(tracing-subscriber/fmt)
    rust-tracing-subscriber+fmt-devel

rust-tracing-subscriber+json-devel:
    crate(tracing-subscriber/json)
    rust-tracing-subscriber+json-devel

rust-tracing-subscriber+local-time-devel:
    crate(tracing-subscriber/local-time)
    rust-tracing-subscriber+local-time-devel

rust-tracing-subscriber+matchers-devel:
    crate(tracing-subscriber/matchers)
    rust-tracing-subscriber+matchers-devel

rust-tracing-subscriber+nu-ansi-term-devel:
    crate(tracing-subscriber/nu-ansi-term)
    rust-tracing-subscriber+nu-ansi-term-devel

rust-tracing-subscriber+once_cell-devel:
    crate(tracing-subscriber/once_cell)
    rust-tracing-subscriber+once_cell-devel

rust-tracing-subscriber+parking_lot-devel:
    crate(tracing-subscriber/parking_lot)
    rust-tracing-subscriber+parking_lot-devel

rust-tracing-subscriber+regex-devel:
    crate(tracing-subscriber/regex)
    rust-tracing-subscriber+regex-devel

rust-tracing-subscriber+registry-devel:
    crate(tracing-subscriber/registry)
    rust-tracing-subscriber+registry-devel

rust-tracing-subscriber+serde-devel:
    crate(tracing-subscriber/serde)
    rust-tracing-subscriber+serde-devel

rust-tracing-subscriber+serde_json-devel:
    crate(tracing-subscriber/serde_json)
    rust-tracing-subscriber+serde_json-devel

rust-tracing-subscriber+sharded-slab-devel:
    crate(tracing-subscriber/sharded-slab)
    rust-tracing-subscriber+sharded-slab-devel

rust-tracing-subscriber+smallvec-devel:
    crate(tracing-subscriber/smallvec)
    rust-tracing-subscriber+smallvec-devel

rust-tracing-subscriber+std-devel:
    crate(tracing-subscriber/std)
    rust-tracing-subscriber+std-devel

rust-tracing-subscriber+thread_local-devel:
    crate(tracing-subscriber/thread_local)
    rust-tracing-subscriber+thread_local-devel

rust-tracing-subscriber+time-devel:
    crate(tracing-subscriber/time)
    rust-tracing-subscriber+time-devel

rust-tracing-subscriber+tracing-devel:
    crate(tracing-subscriber/tracing)
    rust-tracing-subscriber+tracing-devel

rust-tracing-subscriber+tracing-log-devel:
    crate(tracing-subscriber/tracing-log)
    rust-tracing-subscriber+tracing-log-devel

rust-tracing-subscriber+tracing-serde-devel:
    crate(tracing-subscriber/tracing-serde)
    rust-tracing-subscriber+tracing-serde-devel



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-tracing-subscriber --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, fonts, Ocaml, C/C++, R, Python, PHP, Java, SugarActivity, Haskell
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Fabio Valentini 2023-05-29 21:10:09 UTC

Thanks for the review!

(In reply to blinxen from comment #3)
> Taking this review
> 
> General comments:
> 
> - Package was generated with rust2rpm and a feature was removed
> - Feature appears to be unstable, so I guess this is OK

The removed features are gated behind a custom `--cfg` flag, which needs to be passed as RUSTFLAGS="--cfg tracing_unstable" environment variable, which is not supported for RPM builds, so removing them is the only sensible thing we can do.

> - Tests were deactivated because they rely on an unpublished crate. I guess
> this is OK but what is normally done here? Should this be reported to
> upstream?

I don't think this is useful to report to upstream. They choose not to publish the crate that's needed to run the tests, so there's not much we can do.

> - Version 0.3.17 was published

I will update the package before I import it.

> APPROVED

Thanks!

Comment 5 Fedora Admin user for bugzilla script actions 2023-05-29 21:10:41 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tracing-subscriber

Comment 6 Fabio Valentini 2023-05-29 21:43:50 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-60b9675c1f