Bug 2187961

Summary: [RHEL 9.3] Rebase virt-v2v to version 2.3.x
Product: Red Hat Enterprise Linux 9 Reporter: Richard W.M. Jones <rjones>
Component: virt-v2vAssignee: Richard W.M. Jones <rjones>
Status: VERIFIED --- QA Contact: mxie <mxie>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.3CC: chhu, juzhou, lersek, mxie, rjones, tyan, tzheng, vwu, xiaodwan
Target Milestone: rcKeywords: Rebase, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-v2v-2.3.4-2.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Component Upgrade
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2175703    
Bug Blocks:    

Description Richard W.M. Jones 2023-04-19 09:05:40 UTC
Description of problem:

We currently carry 31 downstream patches in RHEL 9.2.  Trying
to backport even a simple fix for bug 2168082 was difficult as the
code has been changed and reformatted a lot upstream.

Since virt-v2v releases are backwards compatible, lets rebase
to the latest version (eg. 2.3.4) instead of backporting.

Version-Release number of selected component (if applicable):

virt-v2v 2.3.4

Comment 2 mxie@redhat.com 2023-04-28 11:27:54 UTC
Random testing for the bug with below builds, the problem found already has been tracked by bug
virt-v2v-2.3.4-1.el9.x86_64
libguestfs-1.50.1-3.el9.x86_64
guestfs-tools-1.50.1-2.el9.x86_64
nbdkit-server-1.34.1-1.el9.x86_64
libvirt-libs-9.2.0-1.el9.x86_64
qemu-img-8.0.0-1.el9.x86_64
virtio-win-1.9.33-0.el9_2.noarch

Comment 6 mxie@redhat.com 2023-07-13 05:48:46 UTC
Verify the bug with below builds:
virt-v2v-2.3.4-5.el9.x86_64
virtio-win-1.9.34-0.el9_2.noarch
libguestfs-1.50.1-6.el9.x86_64
guestfs-tools-1.50.1-3.el9.x86_64
nbdkit-server-1.34.1-1.el9.x86_64
libnbd-1.16.0-1.el9.x86_64
libvirt-libs-9.5.0-0rc1.1.el9.x86_64
qemu-img-8.0.0-7.el9.x86_64

Steps:
1.Build nbdkit packages from src rpm package with regular user
$ rpmbuild --rebuild virt-v2v-2.3.4-5.el9.src.rpm 
...
+ exit 0

2.Convert a windows guest with NTFS from VMware by virt-v2v.Checkpoints of guest are passed after v2v conversion
#  virt-v2v -ic vpx://administrator%40vsphere.local.213.93/data/10.73.212.38/?no_verify=1 -it vddk -io vddk-libdir=/home/vddk8.0.1 -io  vddk-thumbprint=1B:83:D8:5A:33:31:62:DB:BA:9E:73:6D:A8:29:14:48:3F:82:F6:FD  -ip /home/passwd  Auto-esx7.0-win2019-ntfs-3g-bitblocker --key "/dev/sda2":key:VCENTER@redhat2016 --echo-keys 
[   0.0] Setting up the source: -i libvirt -ic vpx://administrator%40vsphere.local.213.93/data/10.73.212.38/?no_verify=1 -it vddk Auto-esx7.0-win2019-ntfs-3g-bitblocker
[   1.8] Opening the source
[  50.2] Inspecting the source
[  58.5] Checking for sufficient free disk space in the guest
[  58.5] Converting Windows Server 2019 Standard to run on KVM
virt-v2v: warning: this guest has Windows Group Policy Objects (GPO) and a 
new virtio block device driver was installed.  In some circumstances, Group 
Policy may prevent new drivers from working (resulting in a 7B boot error). 
 If this happens, try disabling Group Policy before doing the conversion.
virt-v2v: This guest has virtio drivers installed.
[  75.4] Mapping filesystem data to avoid copying unused and blank areas
virt-v2v: warning: fstrim on guest filesystem /dev/mapper/cryptsda2 failed. 
 Usually you can ignore this message.  To find out more read "Trimming" in 
virt-v2v(1).

Original message: fstrim: fstrim: /sysroot/: the discard operation is not 
supported
[  76.2] Closing the overlay
[  76.5] Assigning disks to buses
[  76.5] Checking if the guest needs BIOS or UEFI to boot
[  76.5] Setting up the destination: -o libvirt
[  78.7] Copying disk 1/1
█ 100% [****************************************]
[ 512.2] Creating output metadata
[ 512.3] Finishing off

3. Set cusomter path for virtio-win, then convert a windows guest from VMware by v2v. Checkpoints of guest are passed after v2v conversion

#export VIRTIO_WIN=./virtio-win-1.9.34.iso 
  
#virt-v2v -ic vpx://administrator%40vsphere.local.213.93/data/10.73.212.38/?no_verify=1 -it vddk -io vddk-libdir=/home/vddk8.0.1 -io  vddk-thumbprint=1B:83:D8:5A:33:31:62:DB:BA:9E:73:6D:A8:29:14:48:3F:82:F6:FD  -ip /home/passwd Auto-esx7.0-win2019-x86_64-schtasks-error
[   0.0] Setting up the source: -i libvirt -ic vpx://administrator%40vsphere.local.213.93/data/10.73.212.38/?no_verify=1 -it vddk Auto-esx7.0-win2019-x86_64-schtasks-error
[   1.8] Opening the source
[   7.3] Inspecting the source
[  12.8] Checking for sufficient free disk space in the guest
[  12.8] Converting Windows Server 2019 Standard to run on KVM
virt-v2v: This guest has virtio drivers installed.
[  28.3] Mapping filesystem data to avoid copying unused and blank areas
[  29.5] Closing the overlay
[  29.8] Assigning disks to buses
[  29.8] Checking if the guest needs BIOS or UEFI to boot
[  29.8] Setting up the destination: -o libvirt
[  31.3] Copying disk 1/1
█ 100% [****************************************]
[ 295.3] Creating output metadata
[ 295.4] Finishing off

Result:
   Also do random testing for the bug, no new problem were found, move the bug from ON_QA to VERIFIED