Bug 2188210
| Summary: | uwsgi: uwsgi-plugin-ruby is unusable, not ported to current Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | uwsgi | Assignee: | Ralf Ertzinger <redhat-bugzilla> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kad, python-packagers-sig, redhat-bugzilla |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | uwsgi-2.0.21-7.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-01 02:32:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2137512 | ||
|
Description
Florian Weimer
2023-04-20 06:16:22 UTC
I'm a bit puzzled as to how this ever built against any ruby 3.2.0 package in the first place. In any case, some reading of the ruby side seems to indicate that these functions haven't done anything since ruby 2.7, so I'll gate that out. (In reply to Ralf Ertzinger from comment #1) > I'm a bit puzzled as to how this ever built against any ruby 3.2.0 package > in the first place. GCC allows calling undeclared functions. We are trying to change that for Fedora 39/40, which is why DJ discovered this issue. <https://fedoraproject.org/wiki/Changes/PortingToModernC> <https://fedoraproject.org/wiki/Toolchain/PortingToModernC> FEDORA-2023-eeb6beec79 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-eeb6beec79 (In reply to Fedora Update System from comment #3) > FEDORA-2023-eeb6beec79 has been submitted as an update to Fedora 38. > https://bodhi.fedoraproject.org/updates/FEDORA-2023-eeb6beec79 Looks like this fixed the rack plugin, but not the ruby19 plugin? usr/lib64/ruby -I/usr/lib64/ruby/plugins/ruby19/../rack/rack_plugin.c: In function ‘rack_hack_dollar_zero’: plugins/ruby19/../rack/rack_plugin.c:462:9: warning: implicit declaration of function ‘rb_obj_taint’; did you mean ‘rb_obj_id’? [-Wimplicit-function-declaration] 462 | rb_obj_taint(ur.dollar_zero); | ^~~~~~~~~~~~ | rb_obj_id Oh shoot. The way this is built is a bit strange, the ruby plugin doesn't have any actual code, just build instructions which reference the rack code, but the ruby side isn't setting the flags that would disable that call. I'll build a new version. FEDORA-2023-8d041c38ea has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d041c38ea (In reply to Fedora Update System from comment #6) > FEDORA-2023-8d041c38ea has been submitted as an update to Fedora 38. > https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d041c38ea With this version, there are no implicit function declarations left (as verified with an instrumented compiler). Thanks! Do you plan to upstream the patch? FEDORA-2023-8d041c38ea has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8d041c38ea` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d041c38ea See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8d041c38ea has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |