Bug 2188480

Summary:	vgrename doesn't accept the option --select
Product:	Red Hat Enterprise Linux 9	Reporter:	Corey Marthaler <cmarthal>
Component:	lvm2	Assignee:	Peter Rajnoha <prajnoha>
lvm2 sub component:	Command-line tools	QA Contact:	cluster-qe <cluster-qe>
Status:	CLOSED MIGRATED	Docs Contact:
Severity:	low
Priority:	low	CC:	agk, heinzm, jbrassow, msnitzer, prajnoha, thornber, zkabelac
Version:	9.3	Keywords:	MigratedToJIRA, Triaged
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-23 19:02:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Corey Marthaler 2023-04-20 21:39:34 UTC

Description of problem:
Normally this may not be an issue, but when faced with two vgs with the same name yet unique vg_uuids, many lvm commands tell the user to use vgrename with --select --uuid to remedy the problem.

"Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
Multiple VGs found with the same name: skipping df
Use --select vg_uuid=<uuid> in place of the VG name."




[root@grant-02 ~]# vgs -a -o +vg_uuid
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  VG #PV #LV #SN Attr   VSize VFree VG UUID
  df   1   0   0 wz--n- 2.91t 2.91t iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI
  df   1   0   0 wz--n- 2.91t 2.91t RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo

[root@grant-02 ~]# vgrename df df2
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  Multiple VGs found with the same name: skipping df
  Use --select vg_uuid=<uuid> in place of the VG name.

[root@grant-02 ~]# vgrename --select vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI df2
vgrename: unrecognized option '--select'
  Error during parsing of command line.

[root@grant-02 ~]# vgrename --select 'vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI' df2
vgrename: unrecognized option '--select'
  Error during parsing of command line.

[root@grant-02 ~]# vgremove --select 'vg_uuid=iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI'
  WARNING: VG name df is used by VGs iOF3n2-cigB-O8G2-f4ok-aM0l-IkeJ-NMaJbI and RigPSs-J95t-rj9o-Loc3-HYpw-JRvj-ZpptUo.
  Fix duplicate VG names with vgrename uuid, a device filter, or system IDs.
  Volume group "df" successfully removed


Version-Release number of selected component (if applicable):
kernel-5.14.0-284.11.1.el9_2    BUILT: Wed Apr 12 04:16:55 PM CEST 2023
lvm2-2.03.20-2.el9    BUILT: Thu Apr  6 01:40:29 PM CEST 2023
lvm2-libs-2.03.20-2.el9    BUILT: Thu Apr  6 01:40:29 PM CEST 2023

Comment 1 Peter Rajnoha 2023-05-16 12:04:36 UTC

I think removing the support for -S|--select in vgrename was intentional so we always point to a single VG by directly specifying the VG UUID (which vgrename already accepts).

Also, if we used "vgrename --select <some_criteria> new_vg_name", then all VGs that match the selection criteria would be renamed to the same "new_vg_name". That is something we don't want to as we'd produce duplicate VG names this way.

So the fix here is just to change the reported "Use --select vg_uuid=<uuid> in place of the VG name." line to "Use VG UUID in place of the VG name.".

Comment 2 Peter Rajnoha 2023-05-16 12:05:42 UTC

(And changing all related documentation that mentions -S|--select together with vgrename.")

Comment 3 Peter Rajnoha 2023-05-16 15:27:00 UTC

The message is changed now for commands that do not support -S|--select to "Use VG uuid in place of the VG name." (should be only vgrename at the moment)

https://sourceware.org/git/?p=lvm2.git;a=commit;h=3b4e7d1625ddc48dd9393f03a59cc6b74113275a

Comment 5 RHEL Program Management 2023-09-23 19:00:36 UTC

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 6 RHEL Program Management 2023-09-23 19:02:19 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.